search

HistoryAtState / hsg-shell

Source code for the history.state.gov website
https://history.state.gov
9 stars 13 forks source link

Fix ODD rules for lists #343

Open plutonik-a opened 5 years ago

plutonik-a commented 5 years ago

Possibly a regression bug caused by recent fixes for lists in frus.odd.

1. Nested Lists

image

2. False Font-weight Rendering in Lists

image

3. Lists in Element dateline

image

plutonik-a commented 5 years ago

As I’ve found many variations of lists I wanted to check first with you, how (or if) a simple list without a bullet should be indented: Should a simple list without any bullets or index numbers always have a left margin? Can it be left aligned like normal paragraphs and only following, nested sub lists will be indented?

1st. List example

https://history.state.gov/historicaldocuments/frus1917-72PubDipv07/sources

hsg-shell-list-01

The wrapping list element has no left indentation: hsg-shell-list-02

The nested list will get margin-left, the first element is also a kind of list heading: hsg-shell-list-03

2nd. List example

https://history.state.gov/historicaldocuments/frus1955-57v18/d18

hsg-shell-list-04

hsg-shell-list-05

hsg-shell-list-06

3rd. List example

https://history.state.gov/historicaldocuments/frus1955-57v18/terms

No left indentaion by default here hsg-shell-list-07

plutonik-a commented 5 years ago

@joewiz Regarding the markup of nested lists in general:
Could it be an option to simplify some of the lists and mark-up the content in a flatter structure?

I've found one example for this thought here
-> https://history.state.gov/historicaldocuments/frus1917-72PubDipv07/sources:

Screenshot 2019-11-08 at 11 47 56

This is a list containing only one element, so it could be easily removed and marked as a paragraph and the first <hi rend="strong"/> could be a <head> instead.

joewiz commented 5 years ago

I can confirm that #346—now deployed to history.state.gov—fixes the font issues with italics and smallcaps evident in the initial post above.

@plutonik-a Thank you!

joewiz commented 3 years ago

As reported by @KerryHite:

I was referring to the Person’s List for Reagan vol. III (Soviet Union) and saw that there is something funky going on with the Person’s list. It looks like there is a bullet for each entry superimposed on the second letter. It’s also like that for volume V. It is not like that in Carter Foundations.

See the bullet issue in https://history.state.gov/historicaldocuments/frus1981-88v03/persons, where the list of persons isn't flat but is grouped alphabetically into sublists:

Screen Shot 2020-12-30 at 10 00 52 AM

In contrast, when the list is flat, as in https://history.state.gov/historicaldocuments/frus1977-80v01/persons, there's no bullet issue.

A proper fix to this depends on #345, so I'm noting this here so we can check it when tackling that larger task.