search

HistoryAtState / hsg-shell

Source code for the history.state.gov website
https://history.state.gov
9 stars 13 forks source link

A series of new features for HSG-Shell #417

Closed plutonik-a closed 1 year ago

plutonik-a commented 1 year ago

This open source contribution to the FRUS project was commissioned by the Office of the Historian, U.S. Department of State, https://history.state.gov.

This PR includes following new features (tagged pull requests, sorted from old to new):

Notes:

joewiz commented 1 year ago

@plutonik-a @yamahito Thank you! I've tested all of the features and just have questions about a few:

  1. GitHub reports that the PR has conflicts. Could you please look into these?
  2. Re: eb223 (cover image displayed on volume landing page), I don't see the cover image when accessing a volume's landing page on localhost (or Clementine). Please advise.
  3. Re: eb226 (iiif zoomable images), the new zoomable blocks appear to require a Cantaloupe server running on localhost:8182. We will need this switched to the HSG Cantaloupe server.
  4. Re: eb232 (redirect facility), the redirect facility does not appear to be active. Please advise.
  5. Re: eb237 (social media card facility), I examined the social media card HTML generated by one FRUS landing page, e.g., http://localhost:8080/exist/apps/hsg-shell/historicaldocuments/frus1958-60v03mSupp. I found a long sequence of <meta property="og:image"> elements with @content attributes that contain URLs that are not images, e.g., https://static.history.state.gov/frus/frus1958-60v03mSupp/fig_01. Please advise.
  6. Re: eb239 (sitemaps), building and deploying HSG locally doesn't appear to generate the sitemap or to update an already generated one. Please advise.
  7. Re: eb243 (news section), could you confirm that the landing page isn't using any of the items developed in the "news" feature? (I recall I have an action item to release a new "news" app with the legacy data transformed into the new format.)
yamahito commented 1 year ago

Hi @joewiz - responding to your questions:

  1. We will resolve these.
  2. The S3 cache was not populated on Clementine (it is now); if you update the s3 cache on your localhost, does this resolve the issue?
  3. Agreed: this was seen as a deployment task rather than a code change; we have left the code pointing at localhost for testing for the purposes of this PR. We can update this in resources/scripts/app.js and cantaloupe.properties if you provide the production cantaloupe settings.
  4. Please clarify what expectations are for "active" redirection facility? The code here produces a JSON redirection file when run; this needs to be provided to a CloudFront redirection service configured per instructions at https://github.com/evolvedbinary/hsg-shell/pull/7 .
  5. The og:image content is taken from the TEI /tei:graphic[1]/@url (e.g. line 40967 in frus1977-80v02, "<graphic url="ProjWorldPopulation"/>". Could the issue here be inconsistency in the source TEI?
  6. Sitemaps were not configured to be run automatically either on build or deployment, but by calling the script as detailed in https://github.com/evolvedbinary/hsg-shell/pull/2
  7. Currently the news content is set to use the test data set at /db/apps/hsg-shell/tests/data/news; this is controlled using the variable $config:NEWS_COL which can be updated as soon as your news app is ready.
joewiz commented 1 year ago

@plutonik-a @yamahito Thanks for discussing these just now!