search

Hitchwiki / hitchwiki

The Hitchhiker's Guide to Hitchhiking the World
https://hitchwiki.org
32 stars 9 forks source link

Get rid of Maps extension #139

Closed omelnyk closed 4 years ago

omelnyk commented 7 years ago

Extension:Maps' #coordinates parser function:

{{#coordinates:primary|lat|lng}}

conflicts with Extension:GeoData's #coordinates function:

{{#coordinates:lat,lng}}

We're resorting to a dirty hack to disable the former.

But do we need Maps extension at all? Which of its features are we dependent on?

traumschule commented 7 years ago

Is this the reason why the map tag (<map) is not parsed in the wiki? Would be great to have it enabled again.

simison commented 7 years ago

@traumschule nah, this issues is regarding new unpublished version which is due for a long time already.

<map> in old version is broken just because custom plugin I wrote for got outdated trough several MediaWiki updates. Someone just would need to rewrite it, but it's not really worth the effort at this point.

simison commented 7 years ago

@omelnyk do you remember if you opened an issue at any of those extensions repositories for this?

traumschule commented 6 years ago

The feature "Maps on article pages" was the reason I got involved with HW development. Is this already implemented? I did not manage to see it live yet. I consider it crucial for the new beta (release).

simison commented 6 years ago

@traumschule yep, it's implemented. The map should appear on pages which are created via city or country forms. Something might be broken though, you might want to check if you can see errors at browser console.

But again this issue is about something else than the map sidebar: it's about SemanticMediawiki internals for parsing coordinates.

traumschule commented 6 years ago

hw_pageforms_errors

[81d07c510d298dc48048de0d] [no req] Error from line 1626 of /var/www/public/wiki/extensions/PageForms/includes/PF_FormPrinter.php: Class '\HWLI\HWLocationInput::init' not found

Backtrace:

0 /var/www/public/wiki/extensions/PageForms/includes/PF_FormPrinter.php(1127): PFFormPrinter->formFieldHTML(PFFormField, NULL)

1 /var/www/public/wiki/extensions/PageForms/includes/PF_AutoeditAPI.php(934): PFFormPrinter->formHTML(string, boolean, boolean, integer, string, string, NULL)

2 /var/www/public/wiki/extensions/PageForms/includes/PF_AutoeditAPI.php(115): PFAutoeditAPI->doAction()

3 /var/www/public/wiki/extensions/PageForms/specials/PF_FormEdit.php(92): PFAutoeditAPI->execute()

4 /var/www/public/wiki/extensions/PageForms/specials/PF_FormEdit.php(43): PFFormEdit->printForm(string, string, NULL)

5 /var/www/public/wiki/includes/specialpage/SpecialPage.php(522): PFFormEdit->execute(string)

6 /var/www/public/wiki/includes/specialpage/SpecialPageFactory.php(578): SpecialPage->run(string)

7 /var/www/public/wiki/includes/MediaWiki.php(287): SpecialPageFactory::executePath(Title, RequestContext)

8 /var/www/public/wiki/includes/MediaWiki.php(862): MediaWiki->performRequest()

9 /var/www/public/wiki/includes/MediaWiki.php(523): MediaWiki->main()

10 /var/www/public/wiki/index.php(43): MediaWiki->run()

11 {main}

Retrieved from "http://hitchwiki.test/en/Special:FormEdit/City/Berlin"