search

HiteshriAcharya / pe

0 stars 0 forks source link

Logging reps and sets #5

Open HiteshriAcharya opened 2 months ago

HiteshriAcharya commented 2 months ago

You have added a check for the number of weights and number of sets. But you have not added a check for the number of sets and number of reps. You can do the same.

image.png

nus-se-script commented 2 months ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

We allow logging of 0 reps as some exercises (such as planks) do not have specific rep count. Hence, only negative reps are rejected by the system.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]