Hitman46 / dashclock

Automatically exported from code.google.com/p/dashclock
0 stars 0 forks source link

Prepare weather widget support for multiple languages #112

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
Branch location:

https://code.google.com/r/claudio-dashclock-clone/

Revisions:

Relevant changes where done in f2dded16c3c5 and 5d37125ca826

Reason for request:
Yahoo weather only offers english condition descriptions. As the condition can 
also be determined by using the condition code I did move the descriptions into 
a resources file. This can now easily be translated into any language by 
translating weather_condition_code.xml.

Original issue reported on code.google.com by clau...@the-webers.eu on 14 Feb 2013 at 4:20

GoogleCodeExporter commented 8 years ago
Thanks for preparing this! I'll take a look asap.

Original comment by roman.nurik on 15 Feb 2013 at 4:31

GoogleCodeExporter commented 8 years ago

Original comment by roman.nurik on 15 Feb 2013 at 4:35

GoogleCodeExporter commented 8 years ago
Yeah, this makes a lot of sense. Not quite ready to merge in yet, as I'd like 
to get a bunch of current translations in first, but definitely something to 
look at for the near future.

Original comment by roman.nurik on 15 Feb 2013 at 5:32

GoogleCodeExporter commented 8 years ago
The idea of this patch is to get a base for translation. The newly added xml 
file also needs to be translated, so it would make sense to integrate this 
patch soon so there is a xml file that actually  can be translated by. 
Otherwise the translations will miss the conditions. 

Original comment by clau...@the-webers.eu on 15 Feb 2013 at 5:53

GoogleCodeExporter commented 8 years ago
Yes, understood, but I have a lot of existing translations that I'd like to 
merge in first. Then we'll do another round to get conditions translated.

Original comment by roman.nurik on 15 Feb 2013 at 6:05

GoogleCodeExporter commented 8 years ago
Actually, it looks like we'll be able to get at least some translations 
directly from Yahoo! Weather:

http://developer.yahoo.com/weather/

The "language" option :)

Original comment by roman.nurik on 15 Feb 2013 at 6:07

GoogleCodeExporter commented 8 years ago
Nevermind I misread their API doc. Pardon the rapid comments.

Original comment by roman.nurik on 15 Feb 2013 at 6:11

GoogleCodeExporter commented 8 years ago
I ran into that one as well at first. 

Regarding the translations that's your decision of course, I still would merge 
it asap then newly started translations can include this immediately. The 
existing ones can still be updated anytime later. 

But anyway I don't mind much, as I now have a version that includes translation 
for me including the weather. So I can wait for the official support. 

Btw my clone also includes an updated version of the Germany translation based 
one the one from the issue here including some fixes, typos and the weather 
conditions. 

Original comment by clau...@the-webers.eu on 15 Feb 2013 at 7:01

GoogleCodeExporter commented 8 years ago
Oh, awesome, I'll start merging the German translations in.

Would you like to be credited in the About screen? If so, mind sharing your 
full name? Feel free to email it to me if you prefer.

Original comment by roman.nurik on 15 Feb 2013 at 7:06

GoogleCodeExporter commented 8 years ago
Would be happy to be credited, my name is Claudio Weber. To be clear: The 
german translation is based on the one in issue #17. I just corrected some 
strange xml and typos and did some small changes and of course the weather 
conditions translation. 

Original comment by clau...@the-webers.eu on 15 Feb 2013 at 7:15

GoogleCodeExporter commented 8 years ago
Oops. I missed this issue before I implemented my own version of weather 
condition translations! :(
Anyway, here is my branch, which also contains the Chinese translation for 
weather conditions.
Hope that it will help a bit.

https://code.google.com/r/chenyuheng-zh-dashclock/source/detail?r=0eedde4d316aaa
b7eac19e509948ee1ada0c378d

Original comment by chenyuh...@google.com on 16 Feb 2013 at 1:23

GoogleCodeExporter commented 8 years ago
Hi all! Please take a look at this new document:

http://code.google.com/p/dashclock/wiki/Translation

And make sure to star issue 179

Original comment by roman.nurik on 17 Feb 2013 at 7:18

GoogleCodeExporter commented 8 years ago
Issue 104 has been merged into this issue.

Original comment by roman.nurik on 17 Feb 2013 at 7:51

GoogleCodeExporter commented 8 years ago
Any news? I will be happy if weather can be localized :-) 

Original comment by pyler.in...@gmail.com on 17 Mar 2013 at 3:03