search

Hive-Systems / pyfair

Factor Analysis of Information Risk (FAIR) model written in Python. Managed and maintained by Hive Systems
https://www.hivesystems.com
MIT License
89 stars 45 forks source link

Set another Currency #24

Closed charles-dubos closed 4 years ago

charles-dubos commented 4 years ago

Hi,

Thanks for your work, the result for FAIR analyses is really impressive! However, it would be great to be able to change the currency in the reports (for example € instead of $).

theonaunheim commented 4 years ago

Hello, @charles-dubos .

Thanks for the feedback. A couple of people have brought this oversight to my attention, so this will be included in the next release (0.2-beta.0).

When creating a FairSimpleReport you will be allowed to supply a keyword argument called "currency_prefix". This will allow you to substitute a currency symbol of your choice in the report.

My best guess at this point is roughly 45 days out, but I beleive this change is already active in the "dev" branch should you want to try it out.

charles-dubos commented 4 years ago

Great! It works (only curves have still '$' currencies, but it works perfectly on the tables of the report!)

theonaunheim commented 4 years ago

Thanks for the bug report ... this will allow me to get a putative fix in prior to beta.

theonaunheim commented 4 years ago

@charles-dubos ,

Version 0.2-beta.0 was delayed so I put this into version 0.1-alpha.11 instead. Would you please download the newest version of this package from PyPI, ensure the fix is accurate, and then close this issue at your convenience?

Thank you again for the bug report--much appreciated.