search

HiveMinds / Productivity-phone

Automatically installs (mainly) opensource system on phone that optimizes user productivity.
GNU Affero General Public License v3.0
2 stars 1 forks source link

Code Cleanup & Made code ShellCheck compliant #38

Closed mohitsaxenaknoldus closed 2 years ago

mohitsaxenaknoldus commented 2 years ago

Fixes #20

I've renamed two files that were not installing anything but were still names with the word install.

The custom_install... files mentioned in the issue are named that way because they are part of the custom install process and they looked more intuitive this way to me. However, if you still want me to rename them then let me know I'll do it :)

a-t-0 commented 2 years ago

That is a large amount of work! Thank you for going through the code so consistently!

I've renamed two files that were not installing anything but were still names with the word install. Excellent!

The custom_install... files mentioned in the issue are named that way because they are part of the custom install process and they looked more intuitive this way to me. Thank you for your initiative, making a pragmatic decision and being transparent about it, I think you solved it well like this.

However, if you still want me to rename them then let me know I'll do it :) That will not be necessary, I merged your work into the main branch.

Thank you! I got the GitLab server installation working, so I will spin up the server and see if/how I can set up some mirrors to get that CI badge for these repositories now!