search

HiveMinds / tw-install

Automatically installs Taskwarrior, Taskserver (TODO: and Timewarrior). This project aims to support automated installation of all Taskwarrior hook scripts, configuration flavours etc. with a single command.
GNU Affero General Public License v3.0
17 stars 7 forks source link

Remove unused code. #73

Closed a-t-0 closed 3 years ago

mohitsaxenaknoldus commented 3 years ago

In which files is this unused code?

a-t-0 commented 3 years ago

Hi, thanks for having a look at the repository! The unused code is contained at least in: https://github.com/HiveMinds-EU/Taskwarrior-installation/tree/master/src/examples And in the accompanying tests (pertaining to those example files): https://github.com/HiveMinds-EU/Taskwarrior-installation/tree/master/test

If you detect any additional unused code, feel free to remove it.

mohitsaxenaknoldus commented 3 years ago

Ok, I'll do it. Please assign it to me.

create-issue-branch[bot] commented 3 years ago

Branch issue-73-Remove_unused_code created!

a-t-0 commented 3 years ago

Ok, I'll do it. Please assign it to me.

Awesome! Thank you! For my completeness, were you not able to assign yourself, or did you consider this better protocol? (Otherwise I might have to change settings to enable people to assign themselves.)

mohitsaxenaknoldus commented 3 years ago

Ok, I'll do it. Please assign it to me.

Awesome! Thank you! For my completeness, were you not able to assign yourself, or did you consider this better protocol? (Otherwise I might have to change settings to enable people to assign themselves.)

I couldn't assign myself :(

mohitsaxenaknoldus commented 3 years ago

PR opened: https://github.com/HiveMinds-EU/Taskwarrior-installation/pull/77 Please review @a-t-0

a-t-0 commented 3 years ago

Thank you @mohitsaxenaknoldus ! I have merged your pull request into the main branch, and invited you as collaborator with Triage-capabilities, I hope that enables you to assign yourself to issues if you feel like picking up a challenge! (Feel free to arbitraily test it on some issue (regardless of whether you will work on it or not), and letting me know whether you were indeed able to assign your self (in a comment to that same issue), I would appreciate the feedback!

Also, I took the liberty to remove additional files in the src directory that were not used, removed all the test files and the example files. They are already contained in this repository (for reference) https://github.com/a-t-0/shell_unit_testing_template/tree/main/test and are not used in this Taskwarrior installer. However, this required quite some insight in how this entire code works, so I should have been more clear on that, or explicitly have specified what exactly the intentions were in this issue. Thanks for making that clear to me!

mohitsaxenaknoldus commented 3 years ago

Thanks for the invite! I'll gladly look into the files.

a-t-0 commented 3 years ago

@mohitsaxenaknoldus You're welcome! To be explicitly clear, those files that I mentioned were unused have now been removed, and the pull request has been merged into the main branch. So this issue is closed/completed thanks to your help! :)