search

HiveTalk / hivetalksfu

HiveTalk - Free Nostr + Lightning Enabled Browser based Real-time video calls.
https://hivetalk.org
GNU Affero General Public License v3.0
28 stars 14 forks source link

RTMP URL #37

Closed average-gary closed 1 month ago

average-gary commented 2 months ago

Do meeting have an RTMP URL that can be leveraged for streaming via OBS or similar?

average-gary commented 2 months ago

https://docs.mirotalk.com/mirotalk-sfu/rtmp/

bitkarrot commented 2 months ago

@marathon-gary there is an RTMP server but its coming in next update. no ETA right now.

EthnTuttle commented 2 months ago

@bitkarrot Would you accept a PR to reintroducing the RTMP piece?

bitkarrot commented 2 months ago

All of the changes upstream from mirotalksfu need to pulled in from approximately May 2024 until now (its really not that much afaik.)

Ideally the RTMP should be pulled in and merged along with other package.json dependency changes so no conflicts in 1 PR.

If you are up for the challenge, please feel free to do so!! There is also a current bug in the fonts merge, so latest deploy is 2 commits up the tree. i haven't had time; the next two weeks are kind killer for me in other areas of work.

On Tue, Aug 27, 2024, at 3:23 AM, Ethan Tuttle wrote:

@bitkarrot https://github.com/bitkarrot Would you accept a PR to reintroducing the RTMP piece?

— Reply to this email directly, view it on GitHub https://github.com/HiveTalk/hivetalksfu/issues/37#issuecomment-2312137689, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARUNQQ4N6ESZDULYSCJJOA3ZTRHQ7AVCNFSM6AAAAABM6RG4XKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJSGEZTONRYHE. You are receiving this because you were mentioned.Message ID: @.***>

bitkarrot commented 2 months ago

@bitkarrot Would you accept a PR to reintroducing the RTMP piece?

Yes, I have assigned the PR to you Thanks @EthnTuttle

EthnTuttle commented 2 months ago

I'm going to try a rebase onto their latest stable release branch. Open to alternative ideas as I'm unfamiliar with the codebase.

bitkarrot commented 1 month ago

I'm going to try a rebase onto their latest stable release branch. Open to alternative ideas as I'm unfamiliar with the codebase.

That should work, it will likely be just our renaming that are conflicts, and whatever we added or adjusted. We've tried to keep our fork content as separate as possible.

If it doesn't work out let me know, you can just do the rtmp and I'll cover the rest. The other outstanding PRs from Yeghro shouldn't conflict as its just a UI/UX display update

EthnTuttle commented 1 month ago

oh boy, I rebased and now it won't even let me PR because of the grossly divergent git history. It also seems to have added me as a committer on all the hivetalksfu commits that were rebased. This probably makes this messier than needed, let me try a different strategy.

Edit: I see why, HiveTalk started with an init commit that squashed everything prior. I'll see what I can do.

bitkarrot commented 1 month ago

oh boy, I rebased and now it won't even let me PR because of the grossly divergent git history. It also seems to have added me as a committer on all the hivetalksfu commits that were rebased. This probably makes this messier than needed, let me try a different strategy.

Edit: I see why, HiveTalk started with an init commit that squashed everything prior. I'll see what I can do.

oooh sorry! that was probably my bad. If there is anything I can do to help adjust let me know 🥹

EthnTuttle commented 1 month ago

no worries. I just think a different strategy will be needed to update from mirotalk. I'll take another pass at it soon.

bitkarrot commented 1 month ago

OK i appreciate it. 😄

bitkarrot commented 1 month ago

@EthnTuttle - not sure if you have made any progress with the rebase, we ( me and @jeremyd ) are looking at just forking miro upstream to a new repo and then merging in the changes from this one to make it more easily maintainable moving forward instead of this being its own independent repo; primarly due to the frequent updates from upstream we figure this would be the more efficient way forward.

Do let me know if you have any thoughts. we'll likely be digging in this coming weekend. Also find us on simplex if you're on there.

EthnTuttle commented 1 month ago

I have not had a chance to give it another pass, but my branch might be close to what you're looking for: https://github.com/EthnTuttle/hivetalksfu Maybe I can save you some time on the endeavor. The shared commit history will definitely help with merging in upstream changes.

bitkarrot commented 1 month ago

I think we got it. @jeremyd did a rebase. Thanks @EthnTuttle

EthnTuttle commented 1 month ago

Awesome! Sorry I couldn't land it for you. Is there a timeline for deployment now that it's merged? Also, is there an npub for @jeremyd , I'd like to zap him for his efforts and direct some other interested parties to do so as well.

bitkarrot commented 1 month ago

@EthnTuttle no ETA the moment, I am still working out details along with all of the other open issues. Once it goes live, will be sure to announce on my nostr account

https://nostr.band/npub10npj3gydmv40m70ehemmal6vsdyfl7tewgvz043g54p0x23y0s8qzztl5h