search

HiveTalk / hivetalksfu

HiveTalk - Free Nostr + Lightning Enabled Browser based Real-time video calls.
https://hivetalk.org
GNU Affero General Public License v3.0
30 stars 17 forks source link

Feature toggle autoplay #63

Closed TheWildHustle closed 2 months ago

TheWildHustle commented 2 months ago

Add toggle button for auto-play media setting:

Description
This pull request adds a toggle button in the media settings for the admin to enable or disable auto-play for media. It includes backend API endpoints to get and update the auto-play setting and a frontend component to manage the setting.

Summary of Changes

  1. Add a new property to the Room class to store the auto-play setting.
  2. Update the toJson method to include this setting.
  3. Add methods to get and set the auto-play setting.
  4. Update the relevant parts of the code to check this setting before auto-playing videos.
  5. Backend: Added API endpoints to get and update the auto-play setting.
  6. Frontend: Created a MediaSettings component with a toggle button for the auto-play setting.
bitkarrot commented 2 months ago

We have alternative plans for RTMP, if you would kindly check in with us first before working on this issue. In addition, I'd like to make a strong request not to use React here or additional framework dependencies. We are trying to Keep it clean without use of extraneous frameworks.

Will write up a guideline for contributions as we are aware there is currently isn't one.

With respect to new first time contributions, may I suggest looking at the good first issues?

TheWildHustle commented 2 months ago

Will do!

bitkarrot commented 2 months ago

OK Closing this for now, we will revisit when our plans for rtmp have firmed up. thank you