Closed HariHive closed 4 months ago
If I'm understanding correctly, with this change, we are generating an anonymous ID on odc-api initialization. Then we store it in a new table deviceInfo
for anonymous ID's. This anonymous ID is sent inside of FrameKM metadata.
Just so I understand better, what is the purpose of persisting the anonymous ID if we are creating a new anonymous ID on odc-api start? Is another process using this ID?
If I'm understanding correctly, with this change, we are generating an anonymous ID on odc-api initialization. Then we store it in a new table
deviceInfo
for anonymous ID's. This anonymous ID is sent inside of FrameKM metadata.Just so I understand better, what is the purpose of persisting the anonymous ID if we are creating a new anonymous ID on odc-api start? Is another process using this ID?
@mazar-farran We create an Anonymous ID when not present, i.e create only once and later we use it again and again. That is why I have Insert or Ignore in place for adding anonymous ID into deviceInfo table. I think we eventually want to save all deviceInfo like ssid, serial number and other values also into DeviceInfo table along with Anonymous ID, hence we are persisting the data
Ok, I see, I missed the INSERT OR IGNORE
. Then LGTM
please also add the ticket to the PR description
src/config/index.ts
https://github.com/Hivemapper/docs/issues/361