Hiviexd / MVTaikoChecks

A set of osu!taiko Mapset Verifier checks
3 stars 2 forks source link

check if last note of a map lands on a barline and is snapped 1ms before it #11

Closed Hiviexd closed 1 year ago

Hiviexd commented 1 year ago

uncommon bug but still happens, and when it does, the barline simply doesn't render which isn't supposed to happen, and will result in a pop/dq

it should be a problem check for notes, and a minor check for slider/spinner ends, because this trick tends to be intentionally used for those which is fine lol

additionally it'd be a good idea to add a TaikoUtils function that checks if a note is close to a barline by ±10ms, and a function that checks if a note is snapped to a barline, both functions could be quite useful fir this check and in the future

hongaaronc commented 1 year ago

do you have a map where this happens? I dont think Ive ever seen it before.

im assuming this isnt the same thing as "detached barlines" where the note/barline have different SV?

Hiviexd commented 1 year ago

it resulted in this pop (i also posted about this kind of issue a few more times across the years)

basically, barlines render when there's at least 1 object that's equal or more to their offset, this bug happens because if the last note of a map is right before the barline by 1ms (in the case below, note is on 89411 and barline is on 89412), the barline won't render because there's technically no object on it or after it

.osu diff of the map mentioned above that has the bug: https://nats.are-la.me/8r72MQq.osu