search

Hiviexd / MVTaikoChecks

A set of osu!taiko Mapset Verifier checks
3 stars 3 forks source link

Fix rest moment BPM scaling #13

Closed hongaaronc closed 1 year ago

hongaaronc commented 1 year ago

Resolves #12

Issue

Let's take the hypothetical case of looking at a 120bpm Muzukashii beatmap.

Currently, we are doing the following scaling, using a 1.5x BPM scaling factor:

  1. We're permitting 1/1 as a sufficent break (because 3/2 * 1.5x = 1/1)
  2. We're saying we need breaks every 32/3 (because 16/1 * 1.5x = 32/3, about 11/1) of continuous mapping

However we DO NOT want to be doing # 2, since we are already applying # 1 and applying # 2 would make break structure not align well with common song structures (1 bar = 4 measures = 16/1, which our RC is based around).

Fix

Only apply # 1 but not # 2

hongaaronc commented 1 year ago

Tested on a modified 130 bpm Muzukashii map by putting 1/1 break moments after 20/1 of continuous mapping, then modifying it to 21/1 and trying again and noticing the minor issue gets emitted. Looks good now