search

Hiviexd / MVTaikoChecks

A set of osu!taiko Mapset Verifier checks
3 stars 2 forks source link

Add check for potential stuttering from 1st object offset #15

Closed Hiviexd closed 12 months ago

Hiviexd commented 1 year ago

basically if the offset of the first note is really early, the game will stutter upon hitting the first note which is annoying.

after testing, i found that 150ms is around the sweet spot for when this no longer happens, but i still want to suggest 200ms as the minimum because it's a much safer alternative

would like more opinions on the necessity of the minor check here, and if i can improve my wording on this one

hongaaronc commented 12 months ago

Looks good to me, though it may be worth asking some BNs what the threshold should be for minor issue. I've heard some BNs say as high as 300ms (reference modpost). Maybe ask davidminh0111?

My theory is that it's probably dependent on the audio file format / length, maybe even hardware-dependent too. Compressed formats like .mp3 can introduce latency in the beginning of playback due to needing to take time decompressing (this is why osu hitsounds are required to be .wav) - I suspect this same idea is why stuttering occurs (probably as a measure to resync).

Hiviexd commented 12 months ago

after some more discussion, i've decided against having this check, considering that it all revolves about an unstable bug, and i don't want people to arbitrarily enforce this