search

Hiviexd / MVTaikoChecks

A set of osu!taiko Mapset Verifier checks
3 stars 2 forks source link

Unrankable Finishers Check missing some cases? #18

Closed hongaaronc closed 11 months ago

hongaaronc commented 11 months ago

I was looking at this map, when I noticed that there were some unrankable Futsuu finishers that weren't being caught by MV for some reason?

Unrankable Futsuu Finishers at 00:37:603

I reviewed the code and not sure why it wouldn't catch this. We should look into it a bit more to debug it.

I'm on a different setup currently so don't have my dev environment but I can check it when I get back. Or if anyone else wants to take a look into it now that'd be cool too.

arcs1ne commented 11 months ago

they're 2/3 distance finishers? which are perfectly fine? Lol

unless they're supposed to be pointed out, but i don't think so since the code is currently consistent with the rc on the fact that it only catches 1/3 distance finishers

hongaaronc commented 11 months ago

they're 2/3 distance finishers?

wait youre right im a dumbass....

got baited by this lol