Hiviexd / MVTaikoChecks

A set of osu!taiko Mapset Verifier checks
3 stars 3 forks source link

Add BarlineUnaffectedBySvCheck and refactor Utils classes #25

Closed hongaaronc closed 9 months ago

hongaaronc commented 1 year ago

Resolves #22

Summary

This PR adds a BarlineUnaffectedBySvCheck which is similar to the Base MV's CheckBeforeLine, except it works on barlines. Template format / wording is mostly the same as the base MV one.

Threshold for detecting unsnaps is 5ms - same as base MV's check.

I've also refactored the Utils classes to make them easier to work with.

Testing

hongaaronc commented 1 year ago

Thoughts on emitting minor warning if the offset is off in either direction by an extremely small factor? (this will be emitted on all "perfectly" snapped green lines on barlines.

This will be able to catch https://github.com/Hiviexd/MVTaikoChecks/issues/23 but will also certainly emit a fair amount of false positives.

Personally im thinking we probably shouldnt do this, but I just wanted to throw the idea out there.