In extremely rare cases, barline issues can happen when the notes are perfectly snapped in editor. However, stable has some logic where due to rounding/lack of precision, there actually technically exists a very small unsnap, even though it appears as 0ms in the editor. For examples of these cases, see #23, #24, and #28
Also strangely enough, these rounding errors ONLY exist on stable - they will not occur if the same map is played on Lazer.
This PR will display a warning when this is detected, and asks the user to doublecheck them manually.
I think this is quite important to add, since nowadays more than ever, modders and BNs are becoming more reliant on MV for checking barline issues, and there are still a few that slip through the cracks. This will finally catch those rare edge cases where MV missed them before, and should make it so MV is something we can fully trust in this regard.
Testing
I tested these changes manually on the maps in #23, #24, and #28 . The checks work as expected, and don't seem to appear on other maps where they shouldn't from what I saw.
Screenshots / Examples
0ms last barline hidden detection - Map @ 04:28:703 any diff
Closes #23, #24, #28
Description
In extremely rare cases, barline issues can happen when the notes are perfectly snapped in editor. However, stable has some logic where due to rounding/lack of precision, there actually technically exists a very small unsnap, even though it appears as 0ms in the editor. For examples of these cases, see #23, #24, and #28
Also strangely enough, these rounding errors ONLY exist on stable - they will not occur if the same map is played on Lazer.
This PR will display a warning when this is detected, and asks the user to doublecheck them manually.
I think this is quite important to add, since nowadays more than ever, modders and BNs are becoming more reliant on MV for checking barline issues, and there are still a few that slip through the cracks. This will finally catch those rare edge cases where MV missed them before, and should make it so MV is something we can fully trust in this regard.
Testing
I tested these changes manually on the maps in #23, #24, and #28 . The checks work as expected, and don't seem to appear on other maps where they shouldn't from what I saw.
Screenshots / Examples
0ms last barline hidden detection - Map @
04:28:703any diff0ms Double barline detection 1 - Map @
01:08:944any diff0ms Double barline detection 2 - Map @
02:06:856any diff0ms barline not being affected properly by nearby SV - Map @
03:12:368top diff