Hiviexd / MVTaikoChecks

A set of osu!taiko Mapset Verifier checks
3 stars 2 forks source link

refactor/rework the unrankable finishers check #5

Closed Hiviexd closed 1 year ago

Hiviexd commented 1 year ago

current issues:

hongaaronc commented 1 year ago

Sounds good, I'm down to work on this.

Whats unrankable for inners+ though? or is that like an old RC thing that's no longer relevant? Looks like in the old code its saying faster than 1/4 is unrankable for inners, but Ive definitely seen ranked inners with 1/6 + finisher, such as this one:

I can fix up the kantan->oni parts later this week.

Hiviexd commented 1 year ago

for inner it should just shoot up "ensure it makes sense" warnings for 1/3 (or higher) finishers at the start and middle of patterns, and whenever the finisher is the same color as its preceding/next note in 1/3 or higher