HizurosWoWAddOns / Broker_Everything

A collection of module to display informations about own character, friends, guild and more on minimap or panel addons like Bazooka, ChcolateBar, TitanPanel and more.
GNU General Public License v3.0
9 stars 4 forks source link

[BUG]: 10.0 LUA errors. #16

Closed Nillx closed 1 year ago

Nillx commented 1 year ago

WoW client

WoW Retail

What happened?

Hello, are you planning to update this for 10.0? 9.2.7 version cause a lot of errors but its halfway working.

Lua Error Message?

1x Interface/AddOns/Broker_Everything/Broker_Everything.xml:135 Unrecognized XML attribute: relativeKey

1x Interface/AddOns/Broker_Everything/Broker_Everything.xml:135 Unrecognized XML attribute: point

1x Interface/AddOns/Broker_Everything/Broker_Everything.xml:135 Unrecognized XML: Anchor

1x Interface/AddOns/Broker_Everything/Broker_Everything.xml:134 Unrecognized XML: Anchors

1x Interface/AddOns/Broker_Everything/Broker_Everything.xml:133 Unrecognized XML attribute: y

1x Interface/AddOns/Broker_Everything/Broker_Everything.xml:133 Unrecognized XML attribute: x

1x Interface/AddOns/Broker_Everything/Broker_Everything.xml:133 Unrecognized XML: Size

1x Interface/AddOns/Broker_Everything/Broker_Everything.xml:132 Unrecognized XML attribute: inherits

1x Interface/AddOns/Broker_Everything/Broker_Everything.xml:132 Unrecognized XML attribute: parentKey

1x Interface/AddOns/Broker_Everything/Broker_Everything.xml:132 Unrecognized XML: Checkbox

Other addons?

No response

rodalpho commented 1 year ago

Yes please. The addon actually seems to largely function, my modules show in my LDB display and all, but there are dozens of errors upon login.

rodalpho commented 1 year ago

I went through and corrected every error I saw by commenting out code blocks. Steps: 1) Install the latest release version 2) Download a ZIP of the live code from github 3) Copy all the github files over the release files 4) Replace the Broker_Everything.xml file 5) ... 6) profit

XML file: https://controlc.com/21265af3

Nillx commented 1 year ago

Ok doing that fixed the errors thanks. Noticing an issue with the bag module tho, it thinks my inventory is a 20 slot bag and i have 5 free slots while thats not true.

4C51 commented 1 year ago

This is a duplicate of #13

Spiderkeg commented 1 year ago

I went through and corrected every error I saw by commenting out code blocks. Steps:

  1. Install the latest release version
  2. Download a ZIP of the live code from github
  3. Copy all the github files over the release files
  4. Replace the Broker_Everything.xml file
  5. ...
  6. profit

XML file: https://controlc.com/21265af3

Good job on fixing a lot of these errors. I'm still seeing an error with the volume module, something involving the CVar not being a function. I'm also seeing a lot of addon tab text and module text being surrounded with < > and no idea why.

rodalpho commented 1 year ago

Yes, it breaks all the localization stuff so you only see variable names now. Perfectly usable if you read English, but not pretty. The addon needs a proper fix, not my amateurish attempt.

Spiderkeg commented 1 year ago

Yes, it breaks all the localization stuff so you only see variable names now. Perfectly usable if you read English, but not pretty. The addon needs a proper fix, not my amateurish attempt.

Gotcha. Thanks for the reply and clarification.

JazBlade commented 1 year ago

Ok doing that fixed the errors thanks. Noticing an issue with the bag module tho, it thinks my inventory is a 20 slot bag and i have 5 free slots while thats not true.

I'm seeing that too. It's as if its only counting the default bag slot and not any of the slots you put your own bags into

Calathan198 commented 1 year ago

Yes, it breaks all the localization stuff so you only see variable names now. Perfectly usable if you read English, but not pretty. The addon needs a proper fix, not my amateurish attempt.

If you would actually look at what 4C51 posted he already fixed this. Instead of commenting those lines out you change Checkbox to CheckButton. That fixes those issues.

hizuro commented 1 year ago

Thank you for reporting. Please try version 4.4.1.

Nillx commented 1 year ago

Thanks for the update. Installed 4.4.1 but unfortunately im still getting the same errors. Bag plugin is no longer showing like 3-4 free spots but its still incorrect.

Nillx commented 1 year ago

4.4.2 fixed the issue, im not getting any errors. Bag issue is still present, it constantly change when i move items around my inventory.

Example here(Free bag slots are on the bottom, im moving items around my inventory (Bagnon)): https://imgur.com/a/rEfkuC2