search

HizurosWoWAddOns / Broker_Everything

A collection of module to display informations about own character, friends, guild and more on minimap or panel addons like Bazooka, ChcolateBar, TitanPanel and more.
GNU General Public License v3.0
9 stars 4 forks source link

Equipment Module #2

Closed zaphon closed 2 years ago

zaphon commented 2 years ago

The equipment module is broken in that it makes the assumption that all equipment sets are stored sequentially. This isn't guaranteed as the ID is assigned at creation, and if any sets are deleted in between the ID is not updated. There are 2 locations where you iterate as follows

for i=0, numEquipSets do

If you change both to

for __, i in pairs(C_EquipmentSet.GetEquipmentSetIDs()) do

It fixes it and all sets display correctly.

hizuro commented 2 years ago

Thank you for reporting. Update is available.

zaphon commented 2 years ago

There were 2 places where this occurred. Also at line 49-53 which was missed.

hizuro commented 2 years ago

Oops. Thanks. ;-)

zaphon commented 2 years ago

Hate to nitpick but looks like with the last fix line 220 appears to be inverted (you say no sets found if there is a set).

hizuro commented 2 years ago

"Hate to nitpick" don't worry, it doesn't bother me. ;-) Thank you again...