search

HizurosWoWAddOns / Broker_Everything

A collection of module to display informations about own character, friends, guild and more on minimap or panel addons like Bazooka, ChcolateBar, TitanPanel and more.
GNU General Public License v3.0
10 stars 6 forks source link

Update for showing item uprade levels in Equipment #39

Closed BelegCufea closed 1 year ago

BelegCufea commented 1 year ago

Small fix for not showing upgrade levels in Equipment module. It also shows type of the upgrade (like Explorer, Veteran, Champion ...)

The oneliner on line 1362 can (and maybe should) be split into:

local type, cur, _, max = data.lines[i]:match(S_UPGRADE_LEVEL) type = type:gsub("^%s+", "") -- to remove leading spaces data.upgrades = type .. cur .. "/" .. max

Hope it will not break .. like everything :-(

hizuro commented 1 year ago

Thank you for helping.

Blizzard using another globalstring for the new upgrade line called ITEM_UPGRADE_TOOLTIP_FORMAT_STRING. I've looked into the localized globalstring.lua. Both globalstrings does not match in all languages.

Source: https://www.townlong-yak.com/framexml/live/GlobalStrings.lua

$ grep -rn "ITEM_UPGRADE_TOOLTIP_FORMAT "

DE: ITEM_UPGRADE_TOOLTIP_FORMAT = "Aufwertungsgrad: %d/%d";
ES: ITEM_UPGRADE_TOOLTIP_FORMAT = "Nivel de mejora: %d/%d";
MX: ITEM_UPGRADE_TOOLTIP_FORMAT = "Nivel de mejora: %d/%d";
FR: ITEM_UPGRADE_TOOLTIP_FORMAT = "Niveau d’amélioration : %d/%d";
IT: ITEM_UPGRADE_TOOLTIP_FORMAT = "Livello di potenziamento: %d/%d";
KR: ITEM_UPGRADE_TOOLTIP_FORMAT = "강화 단계: %d/%d";
PT: ITEM_UPGRADE_TOOLTIP_FORMAT = "Nível de aprimoramento: %d/%d";
BR: ITEM_UPGRADE_TOOLTIP_FORMAT = "Nível de aprimoramento: %d/%d";
RU: ITEM_UPGRADE_TOOLTIP_FORMAT = "Уровень улучшения: %d/%d";
CN: ITEM_UPGRADE_TOOLTIP_FORMAT = "升级：%d/%d";
TW: ITEM_UPGRADE_TOOLTIP_FORMAT = "提升等級：%d/%d";
US: ITEM_UPGRADE_TOOLTIP_FORMAT = "Upgrade Level: %d/%d";

$ grep -rn "ITEM_UPGRADE_TOOLTIP_FORMAT_STRING"

DE: ITEM_UPGRADE_TOOLTIP_FORMAT_STRING = "Stufe aufwerten: %s %d/%d";
ES: ITEM_UPGRADE_TOOLTIP_FORMAT_STRING = "Nivel de mejora: %s %d/%d";
MX: ITEM_UPGRADE_TOOLTIP_FORMAT_STRING = "Nivel de mejora: %s %d/%d";
FR: ITEM_UPGRADE_TOOLTIP_FORMAT_STRING = "Niveau d’amélioration : %s %d/%d";
IT: ITEM_UPGRADE_TOOLTIP_FORMAT_STRING = "Livello di potenziamento: %s %d/%d";
KR: ITEM_UPGRADE_TOOLTIP_FORMAT_STRING = "레벨 강화: %s %d/%d";
PT: ITEM_UPGRADE_TOOLTIP_FORMAT_STRING = "Nível de aprimoramento: %s %d/%d";
BR: ITEM_UPGRADE_TOOLTIP_FORMAT_STRING = "Nível de aprimoramento: %s %d/%d";
RU: ITEM_UPGRADE_TOOLTIP_FORMAT_STRING = "Уровень улучшения: %s %d/%d";
CN: ITEM_UPGRADE_TOOLTIP_FORMAT_STRING = "升级：%s %d/%d";
TW: ITEM_UPGRADE_TOOLTIP_FORMAT_STRING = "提升等級：%s %d/%d";
US: ITEM_UPGRADE_TOOLTIP_FORMAT_STRING = "Upgrade Level: %s %d/%d";

Oh... Only one missmatch. :open_mouth:

BelegCufea commented 1 year ago

Nice, thank you for looking into it!

Will close this PR :-)