search

HoI4-LOTRMod-Team / HoI4-LotrMod

Lotr Mod for HoI4
https://hoi4-lotrmod-team.github.io/HoI4-LotrMod/
15 stars 7 forks source link

allow rivendell volunteers #134

Closed awandke closed 8 months ago

awandke commented 9 months ago

closes #133

Helliaca commented 9 months ago

Nice! A couple of notes:

You should work and pull-request on the dev branch (or a derivative thereof) as that is our working branch. The master branch always matches what's currently live on the steam workshop, and only gets merged into when we release an update.

Also, just a suggestion, but since you mentioned the Grey Company: Lothlorien has a "Support the Grey Company" focus. It might be a good idea to copy that focus over into the rivendell tree as well. (And then ensure that only the first one can complete the focus)

awandke commented 9 months ago

okay thank you! I will open future pull requests on dev and take a look at that focus.

awandke commented 8 months ago

restructuring my fork of the repo which caused pull request to close. I am going to open a new one for the same thing.