HoangLiarPhuongLe / javascript__training

0 stars 0 forks source link

fix(refactor): fix comments after review #11

Closed HoangLiarPhuongLe closed 10 months ago

HoangLiarPhuongLe commented 10 months ago
  1. Fixed
    • Image error: fixed ( by deleting )
    • There is a gap between error message and input
    • Fixed the error that input amount was slanted upwards when show error message
    • Rename helpers.js file to format.js
    • Move localStorage to helpers folder
    • Split template.js file into 2 files templateTransaction and templateSummary
    • Update file Readme.md
    • Remove commas between transactions
  2. Haven't fixed yet
    • Show full error message for inputs when successfully adding transaction for the first time
netlify[bot] commented 10 months ago

Deploy Preview for jolly-wisp-9af832 ready!

Name Link
Latest commit dd88223a4248161e1838064d97ffc9615460bc64
Latest deploy log https://app.netlify.com/sites/jolly-wisp-9af832/deploys/6540645fda5ae00007dab7a5
Deploy Preview https://deploy-preview-11--jolly-wisp-9af832.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 10 months ago

Deploy Preview for magenta-puffpuff-9dddbd ready!

Name Link
Latest commit dd88223a4248161e1838064d97ffc9615460bc64
Latest deploy log https://app.netlify.com/sites/magenta-puffpuff-9dddbd/deploys/6540645f574d4b0008017672
Deploy Preview https://deploy-preview-11--magenta-puffpuff-9dddbd.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.