Regression in creator action

[haslinger]

I'm quite sure, that there is a regression in the latest changes to the creator actions. I have the latest github version checked out:

class Conversation
...
  lifecycle do
    state :active, default: true
    create :initiate, become: :active, available_to: :all, new_key: true, params: [:name]
...
  end
...
  def create_permitted?
    true
  end

  def view_permitted?(field)
    customer_is?(acting_user)
  end

and suddenly in the creation method call get

Exception: #<Hobo::PermissionDeniedError: Hobo::PermissionDeniedError>
params:
{"page_path"=>"/conversations/initiate",
 "authenticity_token"=>"flP2yp17m8GBm+mMNtUCaa5Kpvgqb42S7e4wDojCi3A=",
 "conversation"=>
  {"customer_id"=>"1376",
   "name"=>"Bitten rufen Sie mich zurück, meine Telefonnummer ist:"},
 "action"=>"do_initiate",
 "controller"=>"conversations"}

whereas in Hobo 2.1.1 it's still working fine. I have to extend view permissions to

  def view_permitted?(field)
    customer_is?(acting_user) ||
    new_record?
  end

which is fine for me, but I assume, it will break some people's code...

[stevemadere]

This was caused by my PR #147

I mistakenly assumed that HoboModel#user_new was just like ActiveModel#new but with the addition of a call to set_creator() .

I now see that it also invokes user_view for some reason.

I will submit another PR to fix this.

[haslinger]

Cool, thank you, sounds right to me, I will check on sunday it that would fix it for my app...

[haslinger]

I just wanted to confirm, that it's fixed also for my app. Thank you, @stevemadere and @iox for fixing so fast!

[iox]

Nice! :+1: