Add activation_email_url route to routes.rb

[iox]

This is a proposed partial solution to ticket 1022 (https://hobo.lighthouseapp.com/projects/8324-hobo/tickets/1022-possible-issue-with-default-activation-link-with-some-browserswebmails#ticket-1022-3).

The idea is to add a "hardcoded" route in routes.rb, and also change the activation email template. I looked at the hobo_routes generation, but I didn't see a clean way of changing the generated code.

If this solution is found acceptable, I can do the same for accept_invitation and reset_password URLs.

[bryanlarsen]

• It could be added to hobo_routes.rb by adding it to the function user_routes in hobo/lib/generators/hobo/routes/router.rb, although I'm not sure I prefer that.
• I definitely think we shouldn't use the same name as the auto-generated lifecycle route. Having two named routes named the same but producing different routes is going to cause confusion. By the same token, the first part of the route shouldn't be the same either.
• I'm surprised you had to change activation.erb. Rails should generate properly from the :id => @<%= name.underscore -%>, :key => @key form. If not, then it's not hitting the router correctly.

[iox]

Hi Bryan,

This is the current route: http://myserver/users/123456-username/activate?key=64793369eac2b9763a11f9d2d4da92eb71dfbd34

And the proposed: http://myserver/users/123456-username/activate/64793369eac2b9763a11f9d2d4da92eb71dfbd34

Would you prefer something like http://myserver/users/123456-username/activate_from_email/64793369eac2b9763a11f9d2d4da92eb71dfbd34

About editing activation.erb: You are completely right, the change is not necessary.

[bryanlarsen]

That's fine with me On Oct 12, 2012 4:32 AM, "Ignacio Huerta" notifications@github.com wrote:

Hi Bryan,

This is the current route: http://myserver/users/123456-username/activate?key=64793369eac2b9763a11f9d2d4da92eb71dfbd34

And the proposed: http://myserver/users/123456-username/activate/64793369eac2b9763a11f9d2d4da92eb71dfbd34

Would you prefer something like http://myserver/users/123456-username/activate_from_email/64793369eac2b9763a11f9d2d4da92eb71dfbd34

About editing activation.erb: You are completely right, the change is not necessary.

— Reply to this email directly or view it on GitHubhttps://github.com/Hobo/hobo/pull/2#issuecomment-9369718.

[iox]

Hi Bryan, what do you think of the new routes?

[bryanlarsen]

Looks good. Do the same for the other two URL's and go ahead and merge into Hobo.

[iox]

Finished and merging :)