search

Hobo / hobo

The web app builder for Rails (moved from tablatom/hobo)
http://hobocentral.net
103 stars 39 forks source link

Make methodphitamine's It inherit from BlankSlate #29

Closed jpterry closed 11 years ago

jpterry commented 11 years ago

Instead of repeating the same method undefining code as BlankSlate, just inherit from it.

Is there any reason not to do this? Seems more DRY and with BlankSlate defined by hobo I don't see a dependency risk.

iox commented 11 years ago

Integration tests are passing, so I am inclined to merge this. @bryanlarsen , do you agree?

bryanlarsen commented 11 years ago

@iox, that's a little bit risky for the stable branch. But go ahead and merge it into rails4 or fork off a 2-0-stable and then merge it.

iox commented 11 years ago

Ok, I think the rails4 branch makes most sense, good idea :). I'll merge it through another pull request.