Hobo / hobo

The web app builder for Rails (moved from tablatom/hobo)
http://hobocentral.net
103 stars 39 forks source link

Aside does not work in a show page #79

Open iox opened 10 years ago

iox commented 10 years ago

https://groups.google.com/forum/#!topic/hobousers/ElrXwh6gvDI

haslinger commented 10 years ago

I know, it's poor for a developer not to send a pull request (I promise I will learn it), but still:

The relevant line in current Hobo is:
line 134 /hobo/lib/hobo/rapid/generators/rapid/pages.dryml.erb

<page merge title="#{ht '<%=model_key %>.show.title', :default=>['<%=sq_escape model_name %>'], :name => name(:no_wrapper => true) }"<%= ' without-aside' unless aside_collections %> >

I believe changing it to

<page merge title="#{ht '<%=model_key %>.show.title', :default=>['<%=sq_escape model_name %>'], :name => name(:no_wrapper => true) }" >

has no side effects. (But I don't really get why it is currently there.)

iox commented 10 years ago

Thanks a lot Stefan. You don't always have the necessary time to prepare a pull request. I will test a bit your proposed change and see if we get any side effect.

@bryanlarsen introduced this line when he created the theme system, so it must have been for a good reason (https://github.com/Hobo/hobo/commit/365f3f33521aa904ace1860dfbbc97b8600f9124). I'll test it with the different themes.