search

Hobo / hobo_bootstrap_ui

Additional UI tags for the hobo_bootstrap theme
1 stars 8 forks source link

don't use document's language for datepicker language #3

Closed HuBandiT closed 9 years ago

HuBandiT commented 9 years ago

as document's language is hardcoded to 'en' in https://github.com/Hobo/hobo_bootstrap/blob/master/taglibs/page.dryml#L31

this is one potential way of fixing it, see discussion at: https://groups.google.com/forum/#!searchin/hobousers/datepicker/hobousers/0eBz-C9Plr8/sPevKOYust8J

iox commented 9 years ago

As the other PR has been merged. What do you think? Should I close this? @HuBandiT

HuBandiT commented 9 years ago

Yes, close this without applying.

Without this PR applied, it is impossible to change the language per datepicker for current version of the datepicker JS library (1.4.0) - but with the other PR applied all datepickers will use the application's language.

That I think is a reasonable default for most users.

(It might be worth keeping this visible somewhere though so that the next person running into the issue does not have to redo the work. I'm not sure when the other PR will get into effect for most default hobo users - not before a new hobo release I assume.)

iox commented 9 years ago

We just had a Hobo release so... let's close this for now :). Thanks a lot for your nice work.

HuBandiT commented 9 years ago

I agree! Pleasure!