Hochfrequenz / ahbicht

Python Package that parses Condition Expressions from Anwendungshandbüchers ("AHB")
MIT License
4 stars 0 forks source link

Replace `attrs` + `marshmallow` with `pydantic` #478

Open hf-krechan opened 1 week ago

hf-krechan commented 1 week ago

The setup with attrs + marshmallow is not so easy to handle compared to pydantic.

At the moment the marshmallow-jsonschema needs setuptools as dependency which was a default package in the past. But not anymore. It seems to be insecure to add it into a package. I am not (yet) sure why.

We can streamline the dependencies by using just pydantic and it uses the same setup like in our other packages :)

hf-kklein commented 1 week ago

also using marshmallow-enum and marshmallow-jsonschema are more complicated than using pydantic, e.g. https://github.com/fuhrysteve/marshmallow-jsonschema/issues/169

hf-kklein commented 1 week ago

the replacement won't be trivial, because of our own union type-implementation

hf-krechan commented 1 week ago

but nothing which our all stars team can not handle ;)