Hocine078 / open-video-ads

Automatically exported from code.google.com/p/open-video-ads
0 stars 0 forks source link

If an empty non-linear ad tag set is returned in the VAST response, linear impressions are not fired #180

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
If the VAST response returns empty non-linear tags, the impressions are not 
fired for linear ads 
that contain those empty non-linear tags.

        public function processStartAdEvent():void {
            // call the impression tracking urls
            if(hasNonLinearAds() == false) {
                triggerImpressionConfirmations();
            }
            else doLog("===> IMPRESSIONS BEING IGNORED - LINEAR HAS AN OVERLAY");

            // now call the start click tracking urls
            triggerTrackingEvent(TrackingEvent.EVENT_START);
            makeJavascriptAPICall("onLinearAdStart()");
        }

2 things should be changed:

1. Ignore empty ad details 
2. Change the condition to check that it's a linear ad start event

Original issue reported on code.google.com by paul.sch...@gmail.com on 3 Mar 2010 at 11:02

GoogleCodeExporter commented 9 years ago
Went with an approach based on checking to see if the nonLinearAd is actually 
empty - it's deemed to be empty 
if the contents of the URL or CODE tags are 0 in length. Changes made to 
NonLinearVideoAd.isEmpty() and 
VideoAd.hasNonLinearAds()

Requires retest of all impression firing against all examples to ensure no 
knock on consequences.

Original comment by paul.sch...@gmail.com on 3 Mar 2010 at 11:26