HodorNV / ALOps

ALOps
59 stars 24 forks source link

ALOpsAppCompiler@2 ignore Resourceexposurepolicy on runtime <8.0 #466

Closed Arthurvdv closed 2 years ago

Arthurvdv commented 2 years ago

Is your feature request related to a problem? Please describe. We have one template for multiple projects and would like our artifacts (.app files) to have a uniform setting on resourceExposurePolicy and/or showMyCode.

Not all of our projects are on runtime 8.0 (yet), so some need the showMyCode settings, and others would prefer te new resourceExposurePolicy settings.

Describe the solution you'd like ALOpsAppCompiler would read the runtime version of the app.json and when the runtime is lower then 8.0, ignore the resourceExposurePolicy parameters (and thus apply the showMyCode settings if available).

The other way around already seems already to work, when I provide both, showMyCode and resourceExposurePolicy, parameters to the ALOpsAppCompiler the resourceExposurePolicy wins over the showMyCode parameter.

Describe alternatives you've considered Going creative with PowerShell and YAML to try to detect this in our pipelines.

waldo1001 commented 2 years ago

Makes sense .. it's on the list!

waldo1001 commented 2 years ago

It was harder then we expected, but it's part of the latest release ;-).

Arthurvdv commented 2 years ago

Awesome, thanks!