HodorNV / ALOps

ALOps
59 stars 24 forks source link

ALOpsAppValidation: Error on not providing parameter 'license_path' #559

Closed Arthurvdv closed 1 year ago

Arthurvdv commented 2 years ago

Describe the bug When not providing the parameter 'license_path' on the ALOpsAppValidation-step, an error is thrown

##[error]Access to the path 'C:\azure-vsts-agent-build\_work\517\s' is denied.

the used yaml please provide the yaml that you used. It helps you put the yaml like this:

steps:
- task: ALOpsAppValidation@1
  displayName: 'App Validation'
  condition: succeeded()
  inputs:
    affixes: '<redacted>'
    installapps_path: $(System.DefaultWorkingDirectory)\.apps
    artifact_path: $(System.ArtifactsDirectory)
    previousapps_path: $(System.DefaultWorkingDirectory)\App\.appSourceCopPackages
    previousapps_filter: '*.app'
    validatecurrent: true

the output Also the complete output is necessary for us to see what is going on. Also use backtics:

2022-08-19T07:57:37.0571058Z ##[section]Starting: App Validation
2022-08-19T07:57:37.0667375Z ==============================================================================
2022-08-19T07:57:37.0667618Z Task         : ALOps App Validation
2022-08-19T07:57:37.0667797Z Description  : Validate App from Business Central AppSource
2022-08-19T07:57:37.0667964Z Version      : 1.451.3127
2022-08-19T07:57:37.0668094Z Author       : Hodor
2022-08-19T07:57:37.0668263Z Help         : Validate App from Business Central AppSource.
2022-08-19T07:57:37.0668475Z ==============================================================================
2022-08-19T07:57:38.1743568Z *** Validate configuration
2022-08-19T07:57:38.3785071Z *** Task Inputs:
2022-08-19T07:57:38.3819733Z 
2022-08-19T07:57:38.3891074Z name                value                                                          
2022-08-19T07:57:38.3891618Z ----                -----                                                          
2022-08-19T07:57:38.3892656Z license_path        C:\azure-vsts-agent-build\_work\517\s                          
2022-08-19T07:57:38.3893372Z countries                                                                          
2022-08-19T07:57:38.3894222Z affixes             <redacted>                                                    
2022-08-19T07:57:38.3895098Z artifact_path       C:\azure-vsts-agent-build\_work\517\a                          
2022-08-19T07:57:38.3895834Z artifact_filter     *.app                                                          
2022-08-19T07:57:38.3896632Z installapps_path    C:\azure-vsts-agent-build\_work\517\s\.apps                    
2022-08-19T07:57:38.3897438Z installapps_filter  *.app                                                          
2022-08-19T07:57:38.3898178Z previousapps_path   C:\azure-vsts-agent-build\_work\517\s\App\.appSourceCopPackages
2022-08-19T07:57:38.3899099Z previousapps_filter *.app                                                   
2022-08-19T07:57:38.3900044Z memory              8G                                                             
2022-08-19T07:57:38.3901021Z validateversion                                                                    
2022-08-19T07:57:38.3901802Z validatecurrent     True                                                           
2022-08-19T07:57:38.3902747Z validatenextminor   False                                                          
2022-08-19T07:57:38.3903929Z validatenextmajor   False                                                          
2022-08-19T07:57:38.3904913Z sastoken                                                                           
2022-08-19T07:57:38.3905821Z skipverification    False                                                          
2022-08-19T07:57:38.3906803Z skipupgrade         False                                                          
2022-08-19T07:57:38.3907645Z skipappsourcecop    False                                                          
2022-08-19T07:57:38.3908537Z skipconnectiontest  False                                                          
2022-08-19T07:57:38.3909451Z includewarnings     False                                                          
2022-08-19T07:57:38.3910361Z failonerror         True                                                           
2022-08-19T07:57:38.3911378Z containername       bcserver                                                       
2022-08-19T07:57:38.3911523Z 
2022-08-19T07:57:38.3926865Z 
2022-08-19T07:57:38.3933043Z 
2022-08-19T07:57:38.4044717Z *** For documentation, please visit   : https://www.alops.be/documentation
2022-08-19T07:57:38.4046555Z 
2022-08-19T07:57:38.7631925Z *** ALOps License:
2022-08-19T07:57:38.7646233Z   * Licensed To: Van Roey (Collection License)
2022-08-19T07:57:38.7648462Z 
2022-08-19T07:57:38.7966582Z *** Importing required PS-Functions
2022-08-19T07:57:38.8593183Z *** Install/Update BCContainerHelper [https://github.com/microsoft/navcontainerhelper]
2022-08-19T07:57:38.8621171Z *** Check BcContainerHelper
2022-08-19T07:57:38.9134359Z *** Load BcContainerHelper
2022-08-19T07:57:38.9543321Z BcContainerHelper version 3.0.12
2022-08-19T07:57:39.1249306Z BcContainerHelper emits usage statistics telemetry to Microsoft
2022-08-19T07:57:39.8216930Z 
2022-08-19T07:57:39.8218229Z ModuleType Version    Name                                ExportedCommands                                             
2022-08-19T07:57:39.8218733Z ---------- -------    ----                                ----------------                                             
2022-08-19T07:57:39.8219254Z Script     3.0.12     BcContainerHelper                   {Add-FontsToBcContainer, Add-GitToAlProjectFolder, Backup-...
2022-08-19T07:57:39.8219515Z 
2022-08-19T07:57:39.8219665Z 
2022-08-19T07:57:39.8219779Z 
2022-08-19T07:57:39.8220860Z 
2022-08-19T07:57:39.8225069Z *** Setup Flf File: C:\azure-vsts-agent-build\_work\517\s
2022-08-19T07:57:39.8259679Z *** Flf File: C:\azure-vsts-agent-build\_work\517\s
2022-08-19T07:57:39.8263855Z *** Flf Content:
2022-08-19T07:57:39.9603267Z ##[error]Access to the path 'C:\azure-vsts-agent-build\_work\517\s' is denied.
2022-08-19T07:57:39.9826189Z ##[section]Finishing: App Validation

Expected behavior The Run-AlValidation of the BcContainerHelper doesn't need a LicenseFile anymore, see https://github.com/HodorNV/ALOps/issues/558. So not specifing the 'license_path' on the ALOpsAppValidation should not thrown an error.

Screenshots image

waldo1001 commented 2 years ago

We fixed this, will be part of the next release (expected this week).

Arthurvdv commented 1 year ago

I've tested this today by removing the 'license_path' parameter, but still I'm getting the same error?

steps:
- task: ALOpsAppValidation@1
  displayName: 'App Validation'
  condition: succeeded()
  inputs:
    affixes: '<redacted>'
    installapps_path: $(System.DefaultWorkingDirectory)\.apps
    artifact_path: $(System.ArtifactsDirectory)
    previousapps_path: $(System.DefaultWorkingDirectory)\App\.appSourceCopPackages
    previousapps_filter: 'VanRoey*.app'
2022-10-25T08:54:39.9036037Z ==============================================================================
2022-10-25T08:54:39.9036253Z Task         : ALOps App Validation
2022-10-25T08:54:39.9036426Z Description  : Validate App from Business Central AppSource
2022-10-25T08:54:39.9036584Z Version      : 1.453.3279
2022-10-25T08:54:39.9036701Z Author       : Hodor
2022-10-25T08:54:39.9036864Z Help         : Validate App from Business Central AppSource.
2022-10-25T08:54:39.9037067Z ==============================================================================
2022-10-25T08:54:41.2154431Z *** Validate configuration
2022-10-25T08:54:41.4182535Z *** Task Inputs:
2022-10-25T08:54:41.4217748Z 
2022-10-25T08:54:41.4295296Z name                value                                                          
2022-10-25T08:54:41.4295664Z ----                -----                                                          
2022-10-25T08:54:41.4297204Z license_path        C:\azure-vsts-agent-build\_work\152\s                          
2022-10-25T08:54:41.4298691Z countries                                                                          
2022-10-25T08:54:41.4300653Z affixes             <redacted>                                                    
2022-10-25T08:54:41.4301424Z artifact_path       C:\azure-vsts-agent-build\_work\152\a                          
2022-10-25T08:54:41.4301979Z artifact_filter     *.app                                                          
2022-10-25T08:54:41.4302243Z installapps_path    C:\azure-vsts-agent-build\_work\152\s\.apps                    
2022-10-25T08:54:41.4303484Z installapps_filter  *.app                                                          
2022-10-25T08:54:41.4304194Z previousapps_path   C:\azure-vsts-agent-build\_work\152\s\App\.appSourceCopPackages
2022-10-25T08:54:41.4304899Z previousapps_filter VanRoey*.app                                                   
2022-10-25T08:54:41.4305472Z memory              8G                                                             
2022-10-25T08:54:41.4306148Z validateversion                                                                    
2022-10-25T08:54:41.4307079Z validatecurrent     False                                                          
2022-10-25T08:54:41.4307332Z validatenextminor   False                                                          
2022-10-25T08:54:41.4308305Z validatenextmajor   False                                                          
2022-10-25T08:54:41.4308547Z sastoken                                                                           
2022-10-25T08:54:41.4308960Z skipverification    False                                                          
2022-10-25T08:54:41.4309953Z skipappsourcecop    False                                                          
2022-10-25T08:54:41.4310207Z includewarnings     False                                                          
2022-10-25T08:54:41.4310427Z failonerror         True                                                           
2022-10-25T08:54:41.4311426Z containername       bcserver                                                       
2022-10-25T08:54:41.4311557Z 
2022-10-25T08:54:41.4327417Z 
2022-10-25T08:54:41.4335068Z 
2022-10-25T08:54:41.4447843Z *** For documentation, please visit   : https://www.alops.be/documentation
2022-10-25T08:54:41.4449749Z 
2022-10-25T08:54:41.8954355Z *** ALOps License:
2022-10-25T08:54:41.8965151Z   * Licensed To: Van Roey (Collection License)
2022-10-25T08:54:41.8967423Z 
2022-10-25T08:54:41.9274081Z *** Importing required PS-Functions
2022-10-25T08:54:42.0014834Z *** Install/Update BCContainerHelper [https://github.com/microsoft/navcontainerhelper]
2022-10-25T08:54:42.0039688Z *** Check BcContainerHelper
2022-10-25T08:54:42.0560522Z *** Load BcContainerHelper
2022-10-25T08:54:42.1200541Z BcContainerHelper version 4.0.5
2022-10-25T08:54:42.2910270Z BcContainerHelper emits usage statistics telemetry to Microsoft
2022-10-25T08:54:43.3603562Z 
2022-10-25T08:54:43.3604588Z ModuleType Version    Name                                ExportedCommands                                             
2022-10-25T08:54:43.3605012Z ---------- -------    ----                                ----------------                                             
2022-10-25T08:54:43.3605600Z Script     4.0.5      BcContainerHelper                   {Add-FontsToBcContainer, Add-GitToAlProjectFolder, Backup-...
2022-10-25T08:54:43.3605765Z 
2022-10-25T08:54:43.3605815Z 
2022-10-25T08:54:43.3605872Z 
2022-10-25T08:54:43.3609007Z 
2022-10-25T08:54:43.3615499Z *** Setup Flf File: C:\azure-vsts-agent-build\_work\152\s
2022-10-25T08:54:43.3649589Z *** Flf File: C:\azure-vsts-agent-build\_work\152\s
2022-10-25T08:54:43.3654253Z *** Flf Content:
2022-10-25T08:54:43.5251144Z ##[error]Access to the path 'C:\azure-vsts-agent-build\_work\152\s' is denied.
2022-10-25T08:54:43.5488712Z ##[section]Finishing: App Validation