HodorNV / ALOps

ALOps
55 stars 24 forks source link

ALOps App Compiler v2 - Default artifact naming not applied? #737

Open dsaveyn opened 3 months ago

dsaveyn commented 3 months ago

Describe the bug Our artifact names were previously named like Dynavision_Dynavision Admin Module_23.0.1.16956_sandbox_23.1_w1.app. Since last week the naming was changed to Dynavision_Dynavision Admin Module_23.0.5.17813___.app. Our yaml files have not changed and the default value of parameter appfilenametemplate is used. It appears the default naming has changed or is not applied anymore:

image

the used yaml

  - task: ALOpsAppCompiler@2
    displayName: '$(Build.Repository.Name) - ${{ parameters.alsourcepath }} Compile'
    condition: and(succeeded(), eq(${{ parameters.do_step }}, 'true'))
    inputs:
      artifactversion: '$(ALOPS_APPLICATION_VERSION_MAJOR).$(ALOPS_APPLICATION_VERSION_MINOR)'
      artifacttype: ${{ parameters.artifacttype }}
      artifactcountry: $(country)
      appversiontemplate: '?.?.?.*'
      alsourcepath: '$(System.DefaultWorkingDirectory)/${{ parameters.alsourcepath }}'
      failonwarnings: ${{ parameters.failed_on_warnings }}
      publishartifact: false
      showmycode: ${{ parameters.resourceexposurepolicy }}
      resourceexposurepolicy_allowdebugging: ${{ parameters.resourceexposurepolicy }}
      resourceexposurepolicy_allowdownloadingsource: ${{ parameters.resourceexposurepolicy }}
      resourceexposurepolicy_includesourceinsymbolfile: ${{ parameters.resourceexposurepolicy }}
      alternativevsixurl: $(AlternativeVSIXUrl)
      enable_external_rulesets: true

the output

2024-03-13T09:25:01.1321157Z ##[section]Starting: Dynavision Admin Module - License Compile
2024-03-13T09:25:01.1428880Z ==============================================================================
2024-03-13T09:25:01.1429177Z Task         : ALOps App Compiler
2024-03-13T09:25:01.1429411Z Description  : Compile AL Extension(s) for Business Central
2024-03-13T09:25:01.1429641Z Version      : 2.0.5216
2024-03-13T09:25:01.1429804Z Author       : Hodor
2024-03-13T09:25:01.1430032Z Help         : Compile Business Central extension(s) from AL code.
2024-03-13T09:25:01.1430321Z ==============================================================================
2024-03-13T09:25:01.8249831Z ******************************************************************************
2024-03-13T09:25:01.8256952Z *** ALOps v2 - Preview                                                     ***
2024-03-13T09:25:01.8263573Z ******************************************************************************
2024-03-13T09:25:01.8425202Z *** Importing required ALOps-Functions
2024-03-13T09:25:01.9210759Z *** Task Inputs:
2024-03-13T09:25:01.9256695Z 
2024-03-13T09:25:01.9412820Z name                                             value                                                                 
2024-03-13T09:25:01.9416762Z ----                                             -----                                                                 
2024-03-13T09:25:01.9419590Z artifactversion                                  23.1                                                                  
2024-03-13T09:25:01.9422086Z artifacttype                                     Sandbox                                                               
2024-03-13T09:25:01.9426022Z artifactcountry                                  w1                                                                    
2024-03-13T09:25:01.9428798Z versionselect                                    Latest                                                                
2024-03-13T09:25:01.9431371Z alternativeartifacturl                                                                                                 
2024-03-13T09:25:01.9433724Z alternativevsixurl                                                                                                     
2024-03-13T09:25:01.9436519Z alsourcepath                                     F:\Build Agents\BUILD-SERVER 1_1\_work\5\s/License                    
2024-03-13T09:25:01.9438896Z ruleset                                                                                                                
2024-03-13T09:25:01.9441371Z suppresswarnings                                 KEEP                                                                  
2024-03-13T09:25:01.9443837Z appversiontemplate                               ?.?.?.*                                                               
2024-03-13T09:25:01.9446282Z updatebuildnumber                                True                                                                  
2024-03-13T09:25:01.9475756Z appfilenametemplate                              %APP_PUBLISHER%_%APP_NAME%_%APP_VERSION%_%BC_TYPE%_%BC_VERSION%_%BC...
2024-03-13T09:25:01.9477955Z alcodeanalyzer                                                                                                         
2024-03-13T09:25:01.9481291Z ignorepragmas                                                                                                          
2024-03-13T09:25:01.9483320Z enable_external_rulesets                         True                                                                  
2024-03-13T09:25:01.9485268Z showmycode                                       Disable                                                               
2024-03-13T09:25:01.9487160Z resourceexposurepolicy_allowdebugging            Disable                                                               
2024-03-13T09:25:01.9489037Z resourceexposurepolicy_allowdownloadingsource    Disable                                                               
2024-03-13T09:25:01.9491624Z resourceexposurepolicy_includesourceinsymbolfile Disable                                                               
2024-03-13T09:25:01.9493763Z internalsvisibleto                               Keep                                                                  
2024-03-13T09:25:01.9495976Z preprocessorsymbols                                                                                                    
2024-03-13T09:25:01.9498226Z applicationinsightskey                                                                                                 
2024-03-13T09:25:01.9500714Z alcachepath                                      F:\Build Agents\BUILD-SERVER 1_1\_work\5\s                            
2024-03-13T09:25:01.9503059Z publishartifact                                  False                                                                 
2024-03-13T09:25:01.9505411Z publishxlif                                      False                                                                 
2024-03-13T09:25:01.9507797Z failonwarnings                                   True                                                                  
2024-03-13T09:25:01.9510168Z failonany                                        False                                                                 
2024-03-13T09:25:01.9512609Z storageaccount                                                                                                         
2024-03-13T09:25:01.9514890Z sastoken                                                                                                               
2024-03-13T09:25:01.9517275Z printappmanifest                                 True                                                                  
2024-03-13T09:25:01.9519706Z outputalclogs                                    True                                                                  
2024-03-13T09:25:01.9522007Z additionalprobingpaths                                                                                                 
2024-03-13T09:25:01.9524490Z allowed_publisher_names                                                                                                
2024-03-13T09:25:01.9526870Z allowed_publisher_names_separator                ,                                                                     
2024-03-13T09:25:01.9529467Z accept_insider_eula                              False                                                                 
2024-03-13T09:25:01.9531778Z track_source_build_metadata                      True                                         

Expected behavior The naming should be applied as specified in the default value of parameter appfilenametemplate.

As you can see in the output above the default value of appfilenametemplate is present (I'm guessing the ... is because the rest of the value is truncated?)

waldo1001 commented 3 months ago

Fix is coming up - it's all due to the newly "forced" PS7 support. Our apologies...

dsaveyn commented 3 months ago

Thank you very much!