search

HoeenCoder / SpacialGaze

The github repository for the SpacialGaze server on Pokemon Showdown. (We have moved to Wavelength)
Other
4 stars 42 forks source link

Begin fixing deprecation warnings for asynchronous... #355

Closed Mystifi closed 6 years ago

Mystifi commented 7 years ago

...methods without a callback. They now require a callback in order to avoid the deprecation warning, simply because a callback should be passed in order to access the data we're trying to load. This has mostly occurred within trying to write to a file using the asynchronous fs.writeFile, rather than the fs.writeFileSync. I decided to just input a noop so that they still function asynchronously.

Mystifi commented 7 years ago

I don't believe http.get requires a callback, but I decided that adding a notification would be safer anyways.

Pinging @HoeenCoder for overview and assistance finding any more fs.writeFiles or similar instances.