HoeenCoder / Wavelength

The github repository for the Wavelength server on Pokemon Showdown.
http://wavelength.psim.us/
Other
10 stars 46 forks source link

Editorconfig: Increase size to 4 tabs #168

Closed DeathlyPlays closed 6 years ago

DeathlyPlays commented 6 years ago

This is the typical tabs we use when coding I'm pretty certain.

Volco commented 6 years ago

That setting is currently applied by main (from updating with them) https://github.com/Zarel/Pokemon-Showdown/blob/master/.editorconfig#L10 <--- i see issues with merges (extra unnescessary conflicts) caused by this. (just my thoughts) it is hoeen's call on this

DeathlyPlays commented 6 years ago

@Volco yeah I'm aware main did this (they first set it to 2 tabs, but later went up to 3. Howsoever, it's all personal preference (I'm aware HoeenHero and I at least use 4 tabs it looks neater)).

HoeenCoder commented 6 years ago

2 space tabs (looks only, still a tab character) makes it easier to read on github, and prevents conflicts. Id rather leave it as is.