search

HoeenCoder / Wavelength

The github repository for the Wavelength server on Pokemon Showdown.
http://wavelength.psim.us/
Other
10 stars 46 forks source link

Implement Room Shop Plug-in #178

Closed DeathlyPlays closed 6 years ago

DeathlyPlays commented 6 years ago

Tested and ready for reviews

TravisBuddy commented 6 years ago

Travis tests have failed

Hey Insist, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

Node.js: 7.7

npm test ``` > pokemon-showdown@0.11.2 test /home/travis/build/HoeenCoder/Wavelength > eslint --cache . && mocha /home/travis/build/HoeenCoder/Wavelength/wavelength-plugins/roomshop.js 117:330 error 'moneyName' is not defined no-undef 135:48 error 'moneyName' is not defined no-undef 139:104 error 'moneyName' is not defined no-undef 142:104 error 'moneyName' is not defined no-undef 156:69 error 'moneyName' is not defined no-undef ✖ 5 problems (5 errors, 0 warnings) npm ERR! Test failed. See above for more details. ```


TravisBuddy commented 6 years ago

Travis tests have failed

Hey Insist, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

Node.js: 7.7

npm test ``` > pokemon-showdown@0.11.2 test /home/travis/build/HoeenCoder/Wavelength > eslint --cache . && mocha /home/travis/build/HoeenCoder/Wavelength/wavelength-plugins/roomshop.js 154:5 error Parsing error: Unexpected token ) ✖ 1 problem (1 error, 0 warnings) npm ERR! Test failed. See above for more details. ```


TravisBuddy commented 6 years ago

Travis tests have failed

Hey Insist, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

Node.js: 7.7

npm test ``` > pokemon-showdown@0.11.2 test /home/travis/build/HoeenCoder/Wavelength > eslint --cache . && mocha /home/travis/build/HoeenCoder/Wavelength/wavelength-plugins/roomshop.js 154:5 error Parsing error: Unexpected token ) ✖ 1 problem (1 error, 0 warnings) npm ERR! Test failed. See above for more details. ```


Volco commented 6 years ago

@DeathlyPlays please fix the travis error

DeathlyPlays commented 6 years ago

Whoops

DeathlyPlays commented 6 years ago

Wait it is fixed @Volco http://prntscr.com/ioxqqu

DeathlyPlays commented 6 years ago

TravisBuddy is just delayed

Volco commented 6 years ago

oh.... this is why i hate travisbuddy sometimes lol

DeathlyPlays commented 6 years ago

_>

DeathlyPlays commented 6 years ago

Bump @Volco @Mystifi

Volco commented 6 years ago

if myst doesnt return by Saturday i'll merge @DeathlyPlays (myst is a much better reviewer than myself lol this also applies to all prs he reviewed so far too lazy to c/p to all)