search

HoeenCoder / Wavelength

The github repository for the Wavelength server on Pokemon Showdown.
http://wavelength.psim.us/
Other
10 stars 46 forks source link

SSBFFA: Refactor using lib/fs.js #185

Closed DeathlyPlays closed 6 years ago

TravisBuddy commented 6 years ago

Travis tests have failed

Hey Insist, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

Node.js: 7.7

npm test ``` > pokemon-showdown@0.11.2 test /home/travis/build/HoeenCoder/Wavelength > eslint --cache . && mocha /home/travis/build/HoeenCoder/Wavelength/wavelength-plugins/ssb.js 6:5 warning 'noRead' is assigned a value but never used no-unused-vars 606:3 error Expected space(s) after "catch" keyword-spacing ✖ 2 problems (1 error, 1 warning) 1 error, 0 warnings potentially fixable with the `--fix` option. npm ERR! Test failed. See above for more details. ```


TravisBuddy commented 6 years ago

Travis tests have failed

Hey Insist, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

Node.js: 7.7

npm test ``` > pokemon-showdown@0.11.2 test /home/travis/build/HoeenCoder/Wavelength > eslint --cache . && mocha /home/travis/build/HoeenCoder/Wavelength/wavelength-plugins/ssb.js 592:2 error 'noRead' is not defined no-undef ✖ 1 problem (1 error, 0 warnings) npm ERR! Test failed. See above for more details. ```


DeathlyPlays commented 6 years ago

^ taken care of

Volco commented 6 years ago

All works? no errors, no malformed json?

Volco commented 6 years ago

also why did you get rid of the if for noWrite? that makes it useless if the file doesn't exist now or crashes for whatever reason

DeathlyPlays commented 6 years ago

👍 and I removed it because it for some reason caused a bug with not actually making the file like I do now

Volco commented 6 years ago

then why are the other 2 "noWrite" vars still there? remove them in that case please

Volco commented 6 years ago

@DeathlyPlays since the two of the last fs things you did caused crashes did you test this WITH JSON DATA?

DeathlyPlays commented 6 years ago

Test it yourself @Volco

DeathlyPlays commented 6 years ago

I did test

DeathlyPlays commented 6 years ago

Been awhile though

TravisBuddy commented 6 years ago

Travis tests have failed

Hey @DeathlyPlays, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

Node.js: 7.7

npm test ``` > pokemon-showdown@0.11.2 test /home/travis/build/HoeenCoder/Wavelength > eslint --cache . && mocha /home/travis/build/HoeenCoder/Wavelength/wavelength-plugins/ssb.js 583:1 error Parsing error: Missing catch or finally clause ✖ 1 problem (1 error, 0 warnings) npm ERR! Test failed. See above for more details. ```
DeathlyPlays commented 6 years ago

Knew this didn't look right