HoeenCoder / Wavelength

The github repository for the Wavelength server on Pokemon Showdown.
http://wavelength.psim.us/
Other
10 stars 46 forks source link

Friends: Create friend list #190

Closed Volco closed 6 years ago

Volco commented 6 years ago

@Mystifi @HoeenCoder i know this is pretty basic but it's a start. tested and works btw

TravisBuddy commented 6 years ago

Travis tests have failed

Hey @Volco, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

Node.js: 7.7

npm test ``` > pokemon-showdown@0.11.2 test /home/travis/build/HoeenCoder/Wavelength > eslint --cache . && mocha /home/travis/build/HoeenCoder/Wavelength/wavelength-plugins/friends.js 9:6 warning 'friends' is assigned a value but never used no-unused-vars 48:2 error Mixed spaces and tabs no-mixed-spaces-and-tabs 49:2 error Mixed spaces and tabs no-mixed-spaces-and-tabs ✖ 3 problems (2 errors, 1 warning) npm ERR! Test failed. See above for more details. ```
Mystifi commented 6 years ago

This looks decent, I suppose; much better than wgc's. Have the new changes been tested?

Volco commented 6 years ago

You means the ones you requested? not yet been busy

Volco commented 6 years ago

.>when i hit enter too early on the commit should say "and change help back" because this.parse('/help', true) still show the regular help command

Volco commented 6 years ago

@Mystifi tested and fixed

DeathlyPlays commented 6 years ago

Idea: Add optional notifications whenever their friend logs in not just when the user connects

Volco commented 6 years ago

I know i need to figure that out also i know you're suggesting it because you have yet to do it and are going to steal it once i do lol

DeathlyPlays commented 6 years ago

Yup, you got me there

Volco commented 6 years ago

lol