search

HoeenCoder / Wavelength

The github repository for the Wavelength server on Pokemon Showdown.
http://wavelength.psim.us/
Other
10 stars 46 forks source link

Create ambush.js #230

Closed BaneOfAll closed 5 years ago

BaneOfAll commented 5 years ago

Well, the code may have a few bugs, but it should work. I need to know how to search in a file for something.

BaneOfAll commented 5 years ago

Just checked the build log and it's nothing to do with this code. It's

TypeError: Cannot read property '404' of undefined at ClientRequest.onResponse (/home/travis/build/HoeenCoder/Wavelength/node_modules/geoip-lite-country/scripts/updatedb.js:86:97) at Object.onceWrapper (events.js:315:30) at emitOne (events.js:116:13) at ClientRequest.emit (events.js:211:7) at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:558:21) at HTTPParser.parserOnHeadersComplete (_http_common.js:119:17) at TLSSocket.socketOnData (_http_client.js:454:20) at emitOne (events.js:116:13) at TLSSocket.emit (events.js:211:7) at addChunk (_stream_readable.js:263:12)

HoeenCoder commented 5 years ago

Looks like a module is causing issues, would be wise to remove it at this point. Its used in profiles.js. Ill do it later, or you can.

HoeenCoder commented 5 years ago

Ok, the crash with the build is fixed, take a look at the error now. I don't have time to review this now, though I assume you created some new globals/used some that don't exist on wavelength. Double check your work (and make sure its tested & works properly, not just that it dosent crash, I will be checking myself).

Mystifi commented 5 years ago

The build error was simply a result of the geoip module returning the same 404 error as addressed in the PR merged earlier today. This code just needs to be updated to reflect those changes and it should work fine after an overall glance.

Mystifi commented 5 years ago

I would nonetheless highly recommend a detailed review.

BaneOfAll commented 5 years ago

Not entirely sure what I'm meant to do @Mystifi @HoeenCoder you told me different things. Is this crash a result of some other pr?

HoeenCoder commented 5 years ago

Originally, the build failure was. The issue was fixed in #231 and I re-ran the build. Check this for the list of issues to fix. https://travis-ci.org/HoeenCoder/Wavelength/builds/507729445?utm_source=github_status&utm_medium=notification

BaneOfAll commented 5 years ago

@HoeenCoder I have finished this finally. Checks passed

HoeenCoder commented 5 years ago

On hold at this time, see https://github.com/HoeenCoder/Wavelength/projects and #240

HoeenCoder commented 5 years ago

Ok maybe that was a bad idea

HoeenCoder commented 5 years ago

We opted to drop this.