Chat Plugins Refactor

[HoeenCoder]

Chat Plugins are probably the area that needs to most work as they are the most modified. To consider:

• Should we merge all plugins into chat-plugins and drop support for the alternate folder?
  • Pros: Reduced possibility of errors, especially when main changes anything to do with chat-plugin folder functionality.
  • Cons: Folder becomes bigger since it has more plugins (bloat).
• Should we try to merge some related plugins together such as custom colors, avatars, and icons?
  • Pros: Less bloat in the number of files.
  • Cons: Possible bloat in the file instead.

Please try to keep plugins self contained (they stay inside their own file and code in other files is NOT needed) Please ensure all commands have a /help entry

Chat Plugins approved for refactoring and re-adding

• [ ] Custom Colors [colors.js]
• [ ] Custom Avatars [customavatar.js]
• [ ] Dice [dice.js]
• [ ] Digimon Info Plugin [digimon.js] (Digimon Dev Team)
• [ ] Emotes [emoticons.js]
• [ ] Github [github.js] Not currently in the plugin folder so hotpatch chat dosent reload it, maybe we can get around that?
• [ ] Icons [icons.js]
• [ ] Economy Plugin [economy.js] (@Dragotic-PS)
• [ ] News [news.js] Honestly just remove the whole "subscribe" thing and just show it in a PM box when they connect/type a command. (@Mystifi)
• [ ] Permalock/ban Plugin [perma.js]
• [ ] PSGO [psgo.js]
• [ ] Shop Plugin [shop.js formerly eShop.js] (@HoeenCoder)
• [ ] SSBFFA [ssb.js] Fate of this depends on the fate of SSBFFA in #239
• [ ] Surveys [survey.js]

Chat Plugins pending approval before refactoring and re-adding. Refactor at your own risk.

• [x] Ambush [ambush.js #230 ] Not yet added plugin that is a game thats often hosted by bots.
• [ ] Badges [badges.js] Not really used
• [ ] Drafts [drafts.js] Not really used
• [ ] EXP [exp.js] Unsure about an EXP system at this point, may be better to just give dust for stuff
• [ ] Factions [factions.js] Not really used
• [ ] Freinds List [friends.js] Main has one coming "soon" (a while) and idk how I feel about ours atm.
• [x] Gen Requests [genrequests.js] ???
• [ ] Lottery [lottery.js] If users want this, it can stay
• [ ] Misc Plugins [misc.js] Was used as a catch all file, potentially this would be better done in other files. Needs research.
• [x] Modified Plugins/Commands from Main [modified.js] We should potentially just modify them where they originally were from, even if it causes conflicts we can fix them and its important to know when the base code changes for these. Modify the command in its original file.
• [ ] Ontime Plugin [ontime.js] Just records ontime for people
• [ ] Profiles [profile.js] Has always been a pain to maintain and work with, if were keeping it try not to overload it with features and make editing it intuitive.
• [ ] Room Request Plugin [roomrequest.js] Fate of this depends on how we chose to handle rooms in the future.
• [x] Room Shop [roomshop.js] Idk maybe this has a useful purpose. Merged into shop (supports both with less code)
• [ ] Shadow Bans [shadowban.js] Do we even use these? /gban works just as well.
• [x] Splatoon [splatoon.js] I'm a fan of the game but idt it has enough draw here.
• [ ] Staff Help [staffhelp.js] Basically a giant list of staff commands, might be better to automate this rather than making it all hardcoded or just drop it.
• [ ] Tsumeta [tsumeta.js] Fate of this depends on the fate of Tsumeta in #239

If I missed something, or you have opinions on what to keep/remove reply to this. For those that are approved and unclaimed (no parens after the plugin name) feel free to post here to claim it and then refactor it.

[Volco]

Badges - if we implement badge effects like c7 says then keep, otherwise no.

Dice - we have an economy therefore it should stay

Drafts - idc if it goes or not

Exp - like c7 said, it's much harder to get dust without it. Dust will then rely on staff constantly making tours without it which while we did do tours at first. Even if we start making them again i think that will be short lived like last time, life exists.

Factions: @DesoGit other than your bias is there really a need for it? A practical one.

Friends: keep until main's version is out, they've been saying it's in progress for 3/4 years so i call bullshit on it being soon since it's been "soon" that long.

Gen Requests: yeet (get rid of it)

Lottery: users decide is my vote on that

Misc: yeah, it's a mess

Ontime: do we need it? If not yeet it

RR - abstain (policy)

Room Shop - holds off until rooms are actually active, may be useful then

Splatoon - yeet it, useless on WL

SSBFFA - abstain (it's being handled)

Staff help: yes, it would be

Sban: evaders, though we have a vpn filter making it harder so idk

Profile: that needs a refactor really badly, i always hated looking at gold and wisp styled profile plugins, the style looks awful

Tsumeta: abstain (being handled)

Modified: should stay, perhaps add a comment above each plugin with a link to the original modified command. Obvious you'd need to copy the link

Ambush - bots do it already, plus server updates have the potential to break things, could be an issue with on-server ambush. Bots don't have that issue

[ghost]

Gen Requests & Factions are pretty niche unless theres growing support Genning mons are frowned upon in general so id like that to go away I like room shop but agreed with @Volco Ambush is nice but bots can do this so ehhhhh not worth the effort. Shadow Ban is mainly entertainment for staff at this point. if we dont want users speaking we should be up front with a ban t b h

[Mystifi]

I can claim news.js, if you would accept that.

[Mystifi]

Do we really want the proposed hockey plugin at #204? Firstly, if Hoeen wants to go through with the SGgame refactor, then it would have to wait upon that; secondly, how much of the userbase is actually invested in hockey? Would it be used enough to warrant keeping for after the refactor?

[Volco]

@Mystifi outside of Hoeen i don't think many really want a hockey plugin or care. Similar to the splatoom plugin but it's only Hoeen instead of Hoeen and Kraken