search

HoeflingSoftware / Dnn.KeyMaster

MIT License
3 stars 3 forks source link

AppSettings Containing _ Lost when applying KeyMaster #68

Open jmt789 opened 5 years ago

jmt789 commented 5 years ago

Describe the bug The DNN application being used to apply Dnn.KeyMaster to contained some additional app settings which had an _ in the name Ie. "Portal_1". When Dnn.KeyMaster was applied these app settings were not transferred to Azure Key Vault and no warning was given.

To Reproduce Steps to reproduce the behavior: See description above

Expected Behavior Vaues should be transferred to Azure Key Vault (if this is allowed) otherwise a warning should be given.

Actual Behavior Values are lost with no warning given.

Version:

Additional context Add any other context about the problem here.

jmt789 commented 5 years ago

Below is an example of an app setting that didn't transfer.

<add key="portalSqlInstance_0" value="DNN" />

jmt789 commented 5 years ago

Thanks Andrew for the great work on Dnn.KeyMaster :-)

SkyeHoefling commented 5 years ago

Thanks for the feedback on Dnn.KeyMaster, we are glad that you like it so much.

This sounds like a big problem, my guess is going to be _ is giving us issues here. Can you confirm if it is just the properties with _ in the name like you provided portalSqlInstance_0?

Could you provide me a full list of properties that were lost so I can put it in a test case for us to fix.