Hoeijmakers / tayph

Analysis of high resolution spectroscopic time-series of exoplanets
9 stars 8 forks source link

Read_e2ds requires e2ds-data in nm but s1d-data in angstroms. Make uniform? #97

Open Hoeijmakers opened 2 years ago

Hoeijmakers commented 2 years ago

When designing a read-data function in read.py, you presently need to supply e2ds-wavelengths in nm and s1d-wavelengths in angstroms. The angstroms of the s1d data are propagated into the s1ds.pkl for telluric correction (molecfit), as well as measure_RV in read_e2ds(), where they are converted back to nm. This makes no sense and should be made uniform.