search

Hofknecht / SystemTrayMenu

SystemTrayMenu - Browse and open your files easily
http://hofknecht.eu/systemtraymenu/
GNU General Public License v3.0
636 stars 44 forks source link

[BUG] hotkeys etc #481

Open jobsidi opened 1 year ago

jobsidi commented 1 year ago
  1. Hotkeys I cannot set for example win+T via interface, but i can do it via config like setting name="HotKey" serializeAs="String">LWin+T w11
  2. When i mouse over folders sometimes it takes up to few secons. I want to see their content on 0 seconds.
Hofknecht commented 1 year ago

Hey @jobsidi Thank you for the feedback!

Related to 1. Seems LWin+T is a shortcut from windows to tab/switch focus trough taskbar. Most of LWin+Any have already some windows function. I assume that was the reason why we not allowed them.

Related to 2. https://github.com/Hofknecht/SystemTrayMenu/issues/465 Here we have something similar or I explained there how you should manage that it is loaded at the beginning and that you normally don't want to cache everything but only the most necessary. I hope it helps?

jobsidi commented 1 year ago
  1. Win+ hotkeys can be disabled for example via group policy. Anyway SystemTrayMenu allows to bind just to LWin
Hofknecht commented 1 year ago

Yes, you're right. There are of course many other combinations with Ctrl+(Alt)+ ... But don't you think we should also protect the user from using windows combinations, we tried it out for a long time and actually every combination with the windows key is assigned. I think it's very good that you found a workaround to set it, but it may need the skill/protection against overwriting the combination. There can also be side effects with the combination because I think we still have them run by windows and then the focus may be stolen right away or there are only rare side effects. I'm not sure yet if we should just allow this in the settings menu.

jobsidi commented 1 year ago

just add to "expert" tab like "add dangerous combinations" https://github.com/Hofknecht/SystemTrayMenu/issues/465 didnt helped. When i mouse over on dir after showing menu it can take up to 5 seconds to show content. No difference 2 items or 30.

Hofknecht commented 1 year ago

i made 2 videos how it looks from my side

here you can see a network delay, my nas is not reacting fast because hard drives need to start after they are in sleep mode. So also when i double click to windows explorer, the windows explorer is loading. At same time the windows explorer has the informations, the STM is also showing menu with content, meanwhile loading menu shown: https://user-images.githubusercontent.com/52528841/235908146-074f03ea-5d85-463f-94a4-f7b4e4427191.mp4

here i go just through some test folders, to show how fast it should appear normally (video directly after fresh restart) https://user-images.githubusercontent.com/52528841/235908125-bdc808d3-982e-4d4a-a53d-bf3a66bbb31d.mp4

Maybe do you have some more informations, maybe also a video (we made videos with "Apowersoft Free Screen Recorder"). I think we should improve the logfile to have some debug log to see where the times goes. Do you have a hdd or ssd? if you want to that the folder content is cached at STM start you can add Directories like here 2023-05-03 13_56_32- BUG hotkeys etc · Issue #481 · Hofknecht_SystemTrayMenu

topeterk commented 1 year ago

Just a side note, maybe this could be a reason for it?

The icons will be cached but there is a limit: https://github.com/Hofknecht/SystemTrayMenu/blob/master/Utilities/File/IconReader.cs#LL60C75-L60C112

If you have lots of different Icon when the limit is reached the know Icons will be flushed and further Icons will be loaded (again). Try to setup a higher value in the settings at "Expert" -> "Clear cache if more than this number of items".