Hofknecht / SystemTrayMenu

SystemTrayMenu - Browse and open your files easily
http://hofknecht.eu/systemtraymenu/
GNU General Public License v3.0
663 stars 46 forks source link

[BUG] Setting Directory Relative directory should not point to System32 #507

Open OnkelM opened 1 year ago

OnkelM commented 1 year ago

Why do i call this a bug? The term relative indicates to be relative to the parent, hence it should point to the path of the SystemTrayMenu.exe

The current situation also prevents usage in portable situations.

Also if the application cannot open/find the root folder and the popup asks to choose a directory, it should not repeat itself infinite if i click on the Cancel button.

Hofknecht commented 1 year ago

@OnkelM do you mean this button? image this button only makes sense when STM it portable on usb stick and also the root folder is on the the same usb stick and then a relative folder makes sense, therefore we made this button.

if there is no valid path STM can not show any menu, so a valid path is a necessary settings to start the app

OnkelM commented 1 year ago

nevermind i found the issue, the relative path is taken correctly but the application retrieves also the startup folder for the MenuDataDirectoryState which can fail if the SystemTrayMenu.exe is started from another "current" directory.

e.g. running this in cmd "C:\temp> c:\programdata\systemtraymenu\1.3.5.0\systemtraymenu.exe" will result in the error "You have no access to the root directory of the app. Grant access to the directory or change the root directory."

but runnig it while in the correct folder e.g. ""C:\ProgramData\SystemTrayMenu\1.3.5.0> systemtraymenu.exe" will work