srguiwiz
commented
3 years ago Definitely learned in this pull requests from the effect of my actions:
- will try keeping future commits to narrow changes; e.g. split actual change from refactoring
- will avoid having second PR including an earlier commit that is already in a first still open PR, which apparently is what happened (happens?) when doing a PR from a further branch off a first branch; solution appears to be to wait, or stay on one branch, or cancel the first PR
This is a note to myself, or also a comment on the mess I inadvertently caused. Mea culpa.
The older commit 6714000 "Allow user to split a timespan" is explained in PR #40 .
The newer commit 9b6c6f1 "Keep running when removing" is about consistency. If user removes any past timespan, TimeIT keeps recording time, if it is recording. With this PR, the same will be true for the current timespan, for consistency. Removing time with that menu, just as a user action by itself, will not cause recording to stop.
This was triggered in part by noticing in the previous implementation, there was a times entry marked deleted while still running, after a remove. It didn't show in the details list, even though it was running, because it was marked deleted. This will no longer occur after this PR.
The only real change for this "Keep running when removing" has been at the
conditional.