Preprocessing followup - Githubissues

Hold-Krykke / PythonExam

4. Semester Python Eksamens Projekt

1 stars 1 forks source link

Preprocessing followup #11

Closed Runi-VN closed 4 years ago

Runi-VN commented 4 years ago

Followup on remainders from #8

[x] do a regex check [A-Za-z0-9] on hashtags/mentions before adding them to their dict.
~~some testing~~
~~error handling~~
[x] Consider moving aggressive A-Za-z-regex further down the chain? After lemmatisation?
[ ] rename get_tweet_data (wait until merge)
[x] make a sort function for stats
[x] update documentation, mentions still have 'hashtags' in it
[x] remove unnecesary tweet_text check

Unable to fix weird cases like this atm:

Runi-VN commented 4 years ago

Having some issues optimizing the above code. It's not really clean to move the stats-collections in and out of functions, or the text element either.

Hmm.

MrHardcode commented 4 years ago

Is this branch close to ready or ready to be merged with master?

Runi-VN commented 4 years ago

Is this branch close to ready or ready to be merged with master?

Forgot to push, let me clean it up and it'll be ready.