search

HoldUpFjord / Link-Manager

Goal: Create a link manager that can store tabs on a server to be accessed later. 100Devs
2 stars 6 forks source link

Back-End - Corrupted Title with "<", ">" elements from sub-elements to <title> #24

Closed TheWoodenMan closed 2 years ago

TheWoodenMan commented 2 years ago

image with some sites, you can see on the image above, other sub tags are pulled in which corrupts the title.

We need to add logic to instead start or end the slice at the last ">" or the first "<" within the title if present.

that way the readability will much much better and it would cut down on title sizes.

Gonksy commented 2 years ago

Edge case: Twitter: need to slice the title at title="Twitter" instead.

TheWoodenMan commented 2 years ago

I'm going to try and crack this one tonight.

TheWoodenMan commented 2 years ago

Fixed by https://github.com/HoldUpFjord/Link-Manager/pull/33 for titles that are held in title="x"