search

HollowMan6 / mdbook-pdf

A backend for mdBook written in Rust for generating PDF based on headless chrome and Chrome DevTools Protocol. (用 Rust 编写的 mdBook 后端，基于headless chrome和Chrome开发工具协议生成PDF)
https://crates.io/crates/mdbook-pdf
GNU General Public License v3.0
153 stars 18 forks source link

Don't use `mdbook-pdf-headless_chrome` fork #37

Closed wulfgarpro closed 9 months ago

wulfgarpro commented 9 months ago

Hi, thanks for mdbook-pdf!

Why was rust-headless-chrome replaced by mdbook-pdf-headless_chrome in 7250bba20eee89f79d5d5d4eea8050d6f4789a79?

I'd rather use the non-forked version of rust-headless-chrome. For now I'm patching mdbook-pdf at rev 9ea2011de98e30d6f3a04c6b8fe665e71fc29ada.

HollowMan6 commented 9 months ago

It's because they haven't released the patches I submitted to the upstream. The only feasible way is to fork so that I can publish to crates.io:

Since you asked, join https://github.com/rust-headless-chrome/rust-headless-chrome/pull/442#issuecomment-1881736676 and ask to release a new version. I also don't want to spend time maintaining my own fork of rust-headless-chrome.

wulfgarpro commented 9 months ago

Thanks for the explanation.

How about, instead, you specify the git repo dependency until it's released? See https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#specifying-dependencies-from-git-repositories, for more information.

On Thu, 18 Jan 2024, 6:05 pm Hollow Man, @.***> wrote:

It's because they haven't released the patches I submitted to the upstream:

Since you asked, join rust-headless-chrome/rust-headless-chrome#442 (comment) https://github.com/rust-headless-chrome/rust-headless-chrome/pull/442#issuecomment-1881736676 and ask to release a new version. I also don't want to spend time maintaining my own fork of rust-headless-chrome.

— Reply to this email directly, view it on GitHub https://github.com/HollowMan6/mdbook-pdf/issues/37#issuecomment-1897918689, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHJHNBV7ULRQ77FRHMIQJLYPDCU5AVCNFSM6AAAAABB7NVKTWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJXHEYTQNRYHE . You are receiving this because you authored the thread.Message ID: @.***>

HollowMan6 commented 9 months ago

It's because they haven't released the patches I submitted to the upstream. The only feasible way is to fork so that I can publish to crates.io:

Thanks for the explanation. How about, instead, you specify the git repo dependency until it's released? See https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#specifying-dependencies-from-git-repositories for me information.

Then I can't publish mdbook-pdf to crates.io. Read carefully to see the note in the link you mentioned:

Note: crates.io does not allow packages to be published with dependencies on code published outside of crates.io itself

wulfgarpro commented 9 months ago

Looks like a new version was released last week: https://github.com/rust-headless-chrome/rust-headless-chrome/releases/tag/v1.0.9.

HollowMan6 commented 9 months ago

Now updated and released v0.1.8