PassiveTotal service

[ms-xy]

Query PassiveTotal.org for enrichment data to Domains, IPs, Emails, or Indicators.

[webstergd]

Lets code review this. I would like to learn more about what you did and why. should be good for the other to learn as well.

[ms-xy]

Didn't realize that you changed the ports and that we now have special port ranges for specific services. (It's still alphabetical, so I inserted it where it would have gone if it was still purely alphabetical as it was before). I'll adjust that in a moment.

Edit: regarding code-review, just tell me when and I'll be ready.

[webstergd]

yeah with GSoC finishing up this weekend, we had lots and lots of pull requests.

[ms-xy]

Lets discuss what to do about the error codes in the code-review, I'm not entirely certain how to handle request errors, as we don't have partial result sets in Totem (?).

[ms-xy]

Updated the pull request, added error codes as requested, improved the object type detection mechanism. Some other small fixes and cosmetic changes too. Took out SSL API query as discussed with @webstergd .

[webstergd]

last few things and i think this is ready:

• [x] change folder name to passivetotal
• [x] explain in your readme how I can task a domain, ip, or email.
• [x] run the code though go fmt

[ms-xy]

The only file that I did not go-fmt is the config file. This is because it will be removed in a pull request soon anyways (will be creating a golang config parsing equivalent in the holmes-library, plus the switch to json config files, which makes this ini config parser obsolete anyways).

[webstergd]

Thanks ms-xy. This looks good to me.

I like your identification and validation methods for the ip, domain, and email address. We should eventually move this to the library and make this standard.