VirusTotal service patch

HolmesProcessing / Holmes-Totem

Investigation Planner for fast running analysis with predictable execution time. For example, static analysis.

Apache License 2.0

29 stars 18 forks source link

VirusTotal service patch #118

Closed ms-xy closed 8 years ago

ms-xy commented 8 years ago

Added RequestTimeout setting (otherwise unlimited, worst case piling up requests, see: https://golang.org/pkg/net/http/#Client)
Uniform logger usage

webstergd commented 8 years ago

we should also probably add a max timeout for checking after uploading samples. Right now it is a loop with a delay for 5 minutes that i believe just keeps trying until it gets a 200.

webstergd commented 8 years ago

Got catch ms-xy. This fixes a rare issue that in theory should not occur. However, you are totally correct it is possible. In the future, we should still probably add a max wait time out as well.